Re: leak if jspServlet.destroy() fails

2016-07-26 Thread Mark Thomas
On 13/07/2016 19:55, Romain Manni-Bucau wrote: > well the instanceManager.destoy should be called whatever happens I think This has been fixed in all supported versions for the next release of each. Mark > > > Romain Manni-Bucau > @rmannibucau | Blog >

Re: leak if jspServlet.destroy() fails

2016-07-13 Thread Romain Manni-Bucau
well the instanceManager.destoy should be called whatever happens I think Romain Manni-Bucau @rmannibucau | Blog | Old Wordpress Blog | Github | LinkedIn <

Re: leak if jspServlet.destroy() fails

2016-07-13 Thread Violeta Georgieva
Hi, 2016-07-12 23:53 GMT+03:00 Romain Manni-Bucau : > > Hi all, > > is (jsp) generated code for tags suffering from the same kind of issue? For > a c:out I get: > > > private boolean > _jspx_meth_c_005fout_005f0(javax.servlet.jsp.PageContext > _jspx_page_context) > throws java.lang.Throwab

Re: leak if jspServlet.destroy() fails

2016-07-12 Thread Romain Manni-Bucau
Hi all, is (jsp) generated code for tags suffering from the same kind of issue? For a c:out I get: private boolean _jspx_meth_c_005fout_005f0(javax.servlet.jsp.PageContext _jspx_page_context) throws java.lang.Throwable { javax.servlet.jsp.PageContext pageContext = _jspx_page_context;

Re: leak if jspServlet.destroy() fails

2016-07-01 Thread Mark Thomas
On 01/07/2016 17:28, Romain Manni-Bucau wrote: > Think org.apache.jasper.runtime.TagHandlerPool#release can be affected too > - I'm not sure where it is called in the codebase but the pattern is the > same. I've doing a review of all calls to destroyInstance() now. There is at least one further is

Re: leak if jspServlet.destroy() fails

2016-07-01 Thread Romain Manni-Bucau
Think org.apache.jasper.runtime.TagHandlerPool#release can be affected too - I'm not sure where it is called in the codebase but the pattern is the same. Romain Manni-Bucau @rmannibucau | Blog | Old Wordpress Blog

Re: leak if jspServlet.destroy() fails

2016-07-01 Thread Romain Manni-Bucau
+1 Romain Manni-Bucau @rmannibucau | Blog | Old Wordpress Blog | Github | LinkedIn | Tomitriber

Re: leak if jspServlet.destroy() fails

2016-07-01 Thread Mark Thomas
On 01/07/2016 16:41, Romain Manni-Bucau wrote: > Hello guys, > > if a jspDestroy() throws an Exception then the instance manager is not > called which can lead to some leaks depending the implementation (see > org.apache.jasper.servlet.JspServletWrapper#destroy) > > Would it be possible to have a

leak if jspServlet.destroy() fails

2016-07-01 Thread Romain Manni-Bucau
Hello guys, if a jspDestroy() throws an Exception then the instance manager is not called which can lead to some leaks depending the implementation (see org.apache.jasper.servlet.JspServletWrapper#destroy) Would it be possible to have a way to release/cleanup the jsp context through the instance