On 01/07/2016 17:28, Romain Manni-Bucau wrote: > Think org.apache.jasper.runtime.TagHandlerPool#release can be affected too > - I'm not sure where it is called in the codebase but the pattern is the > same.
I've doing a review of all calls to destroyInstance() now. There is at least one further issue as well as the tag one you spotted. Mark > > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber > <http://www.tomitribe.com> | JavaEE Factory > <https://javaeefactory-rmannibucau.rhcloud.com> > > 2016-07-01 18:10 GMT+02:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > >> +1 >> >> >> Romain Manni-Bucau >> @rmannibucau <https://twitter.com/rmannibucau> | Blog >> <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog >> <http://rmannibucau.wordpress.com> | Github >> <https://github.com/rmannibucau> | LinkedIn >> <https://www.linkedin.com/in/rmannibucau> | Tomitriber >> <http://www.tomitribe.com> | JavaEE Factory >> <https://javaeefactory-rmannibucau.rhcloud.com> >> >> 2016-07-01 18:06 GMT+02:00 Mark Thomas <ma...@apache.org>: >> >>> On 01/07/2016 16:41, Romain Manni-Bucau wrote: >>>> Hello guys, >>>> >>>> if a jspDestroy() throws an Exception then the instance manager is not >>>> called which can lead to some leaks depending the implementation (see >>>> org.apache.jasper.servlet.JspServletWrapper#destroy) >>>> >>>> Would it be possible to have a way to release/cleanup the jsp context >>>> through the instance manager or to call destroyInstance properly? >>> >>> I think wrapping the call to destroy in a try/catch would be the way to >>> go. It would be worth a check to see if there are any other places where >>> similar issues could occur with JSPs. >>> >>> Mark >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >>> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
