Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 18:02, Michael Roberts wrote: >> >> 3) As mentioned, the chat example maintains a list of connections. Connections (MessageInbound instances) are added to this list when connections are established. However, they are never removed when the connection is closed, so

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Michael Roberts
Thanks, comments below. I'm going to address the chat example connection pruning in a separate mail. >> 1) In the createWebSocketInbound method implemented by the chat example's > >> subclass of WebSocketServlet, there is seemingly no way to interrogate > the > >> incoming request for information

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Michael Roberts
> > > >> 3) As mentioned, the chat example maintains a list of connections. > >> Connections (MessageInbound instances) are added to this list when > >> connections are established. However, they are never removed when the > >> connection is closed, so the list grows. The broadcast method silentl

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 10:20, Mark Thomas wrote: > On 19/06/2012 06:16, Michael Roberts wrote: >> Hi, I have been playing with the web sockets support in 7.0.27. I have >> some comments and, as requested in the readme, am sending them to the dev >> list. > > Thanks. Much appreciated. > >> Caveat: it's be

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 06:16, Michael Roberts wrote: > Hi, I have been playing with the web sockets support in 7.0.27. I have > some comments and, as requested in the readme, am sending them to the dev > list. Thanks. Much appreciated. > Caveat: it's been a while since .27, so perhaps some of these issue

WebSocketServlet (and chat example) comments

2012-06-18 Thread Michael Roberts
Hi, I have been playing with the web sockets support in 7.0.27. I have some comments and, as requested in the readme, am sending them to the dev list. Caveat: it's been a while since .27, so perhaps some of these issues are addressed in the nightly builds. Anyhow, here we go: 1) In the createWe