Re: ServiceBindingPropertySource

2024-05-27 Thread Felix Schumacher
Chris, Am 27.05.24 um 15:51 schrieb Christopher Schultz: Rémy, On 5/22/24 06:14, Rémy Maucherat wrote: On Wed, May 22, 2024 at 9:06 AM Mark Thomas wrote: On 21/05/2024 18:50, Christopher Schultz wrote: 1. Allow ServiceBindingPropertySource to use the SERVICE_BINDING_ROOT environment

Re: ServiceBindingPropertySource

2024-05-27 Thread Felix Schumacher
it uses an environment variable SERVICE_BINDING_ROOT which is in line with the service binding standard which is documented https://servicebinding.io/. Environment variables are a little icky in Java, so I'd like to do one or more of the following: 1. Allow ServiceBindingPropertySo

Re: ServiceBindingPropertySource

2024-05-27 Thread Christopher Schultz
line with the service binding standard which is documented https://servicebinding.io/. Environment variables are a little icky in Java, so I'd like to do one or more of the following: 1. Allow ServiceBindingPropertySource to use the SERVICE_BINDING_ROOT environment variable *or* a system p

Re: ServiceBindingPropertySource

2024-05-27 Thread Christopher Schultz
Rémy, On 5/22/24 06:14, Rémy Maucherat wrote: On Wed, May 22, 2024 at 9:06 AM Mark Thomas wrote: On 21/05/2024 18:50, Christopher Schultz wrote: 1. Allow ServiceBindingPropertySource to use the SERVICE_BINDING_ROOT environment variable *or* a system property with an appropriate name such

Re: ServiceBindingPropertySource

2024-05-22 Thread Felix Schumacher
documented https://servicebinding.io/. Environment variables are a little icky in Java, so I'd like to do one or more of the following: 1. Allow ServiceBindingPropertySource to use the SERVICE_BINDING_ROOT environment variable *or* a system property with an appropriate name such as servi

Re: ServiceBindingPropertySource

2024-05-22 Thread Rémy Maucherat
On Wed, May 22, 2024 at 9:06 AM Mark Thomas wrote: > > On 21/05/2024 18:50, Christopher Schultz wrote: > > > > > 1. Allow ServiceBindingPropertySource to use the SERVICE_BINDING_ROOT > > environment variable *or* a system property with an appropriate name > > s

Re: ServiceBindingPropertySource

2024-05-22 Thread Mark Thomas
On 21/05/2024 18:50, Christopher Schultz wrote: 1. Allow ServiceBindingPropertySource to use the SERVICE_BINDING_ROOT environment variable *or* a system property with an appropriate name such as service.binding.root, with the system property overriding the environment variable. Seems

ServiceBindingPropertySource

2024-05-21 Thread Christopher Schultz
iables are a little icky in Java, so I'd like to do one or more of the following: 1. Allow ServiceBindingPropertySource to use the SERVICE_BINDING_ROOT environment variable *or* a system property with an appropriate name such as service.binding.root, with the system property overriding t

[GitHub] [tomcat] musky74 commented on pull request #512: Adding a ServiceBindingPropertySource

2022-05-17 Thread GitBox
musky74 commented on PR #512: URL: https://github.com/apache/tomcat/pull/512#issuecomment-1128981647 Ty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[tomcat] branch 8.5.x updated: Adding a ServiceBindingPropertySource

2022-05-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 038bf486b1 Adding a ServiceBindingPropertySource

[tomcat] branch 9.0.x updated: Adding a ServiceBindingPropertySource

2022-05-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 53d572b93e Adding a ServiceBindingPropertySource

[tomcat] branch 10.0.x updated: Adding a ServiceBindingPropertySource

2022-05-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 0b898bfb8e Adding a ServiceBindingPropertySource

[tomcat] branch main updated: Adding a ServiceBindingPropertySource

2022-05-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new ba7f29a0cb Adding a ServiceBindingPropertySource

[GitHub] [tomcat] markt-asf merged pull request #512: Adding a ServiceBindingPropertySource

2022-05-10 Thread GitBox
markt-asf merged PR #512: URL: https://github.com/apache/tomcat/pull/512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] markt-asf commented on pull request #512: Adding a ServiceBindingPropertySource

2022-05-10 Thread GitBox
markt-asf commented on PR #512: URL: https://github.com/apache/tomcat/pull/512#issuecomment-1122616275 Agreed. I was going to merge this, tidy things up a bit and then back-port. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat] ChristopherSchultz commented on pull request #512: Adding a ServiceBindingPropertySource

2022-05-10 Thread GitBox
ChristopherSchultz commented on PR #512: URL: https://github.com/apache/tomcat/pull/512#issuecomment-1122565867 This looks interesting to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [tomcat] garethjevans opened a new pull request, #512: Adding a ServiceBindingPropertySource

2022-05-10 Thread GitBox
garethjevans opened a new pull request, #512: URL: https://github.com/apache/tomcat/pull/512 The property source allows values in Tomcat's configuration files to be injected directly from a servicebinding.io's Service Binding without having to be converted to an environment variable