On Wed, May 22, 2024 at 9:06 AM Mark Thomas <ma...@apache.org> wrote:
>
> On 21/05/2024 18:50, Christopher Schultz wrote:
>
> <snip/>
>
> > 1. Allow ServiceBindingPropertySource to use the SERVICE_BINDING_ROOT
> > environment variable *or* a system property with an appropriate name
> > such as service.binding.root, with the system property overriding the
> > environment variable.
>
> Seems reasonable to me but keep in mind I've never used this code.
I haven't either, it's been contributed.
I don't really understand why the change overall, Kube uses the
environment and never the system properties.
> > 2. Have ServiceBindingPropertySource fall-back to system property
> > resolution if no matching file is found. Maybe we should do this with
> > all PropertySource classes provided by Tomcat?
>
> My reading of the docs and the code is that SystemPropertySource is
> always added already.
Yes, SystemPropertySource is added. Does it not work properly ?
> > 3. If the SERVICE_BINDING_ROOT environment variable is being used, copy
> > its value into a system property. This will allow application software
> > or Tomcat itself to use the file reference as necessary. For example:
>
> Again seems reasonable to me but same caveat as above.
The resolution should work as it is already given the javadocs from
ServiceBindingPropertySource.
At this point it would seem easier to simply add
-Dservice.binding.root=${SERVICE_BINDING_ROOT} to the Catalina
options.
Rémy
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
