Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-10-01 Thread sebb
On 29/09/2008, Mark Thomas <[EMAIL PROTECTED]> wrote: > sebb wrote: > > On 29/09/2008, Mark Thomas <[EMAIL PROTECTED]> wrote: > > >> ThreadLocals and container classloader environments need careful handling > >> to avoid memory leaks. > > > > I would have thought that was a good reason to kee

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-29 Thread Mark Thomas
sebb wrote: > On 29/09/2008, Mark Thomas <[EMAIL PROTECTED]> wrote: >> ThreadLocals and container classloader environments need careful handling >> to avoid memory leaks. > > I would have thought that was a good reason to keep the class - one > only needs to get the code right once? If you don't

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-29 Thread sebb
On 29/09/2008, Mark Thomas <[EMAIL PROTECTED]> wrote: > sebb wrote: > > BTW, Commons LANG has a thread-safe FastDateUtils which can be used > > for formatting (but not parsing) dates. > > A whole jar for one method is somewhat overkill. Indeed, but there's lots of other useful stuff in LANG. I j

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-29 Thread Mark Thomas
sebb wrote: > BTW, Commons LANG has a thread-safe FastDateUtils which can be used > for formatting (but not parsing) dates. A whole jar for one method is somewhat overkill. > Not sure why you did not just fix DateTool - e.g. by using ThreadLocal > (or indeed synchronizing the use of DateFormats) -

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-29 Thread sebb
BTW, Commons LANG has a thread-safe FastDateUtils which can be used for formatting (but not parsing) dates. Not sure why you did not just fix DateTool - e.g. by using ThreadLocal (or indeed synchronizing the use of DateFormats) - rather than fixing all calls to DateTool. Or maybe I've misunderstoo