BTW, Commons LANG has a thread-safe FastDateUtils which can be used for formatting (but not parsing) dates.
Not sure why you did not just fix DateTool - e.g. by using ThreadLocal (or indeed synchronizing the use of DateFormats) - rather than fixing all calls to DateTool. Or maybe I've misunderstood something here. It would be useful to add a comment to the declaration of private static final DateFormat format to say that all access to the format must be synchronized. On 29/09/2008, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: markt > Date: Mon Sep 29 09:30:34 2008 > New Revision: 700170 > > URL: http://svn.apache.org/viewvc?rev=700170&view=rev > Log: > Propose mew fix for date format thread safety > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: > http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=700170&r1=700169&r2=700170&view=diff > > ============================================================================== > --- tomcat/tc6.0.x/trunk/STATUS.txt (original) > +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Sep 29 09:30:34 2008 > @@ -236,3 +236,10 @@ > Note: Deleted getETag(boolean) method to remain but deprecated > +1: markt, remm (I was -1 originally, but it may not be so bad) > -1: > + > +* Fix some thread safety issues. > + Deprecate (rather than delete) any deleted code that isn't already > deprecated > + http://svn.apache.org/viewvc?rev=699714&view=rev (previous patch) > + http://svn.apache.org/viewvc?rev=700167&view=rev (additional changes) > + +1: mark > + -1: > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
