Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Rainer Jung
On 21.10.2010 21:21, Mladen Turk wrote: On 10/21/2010 09:16 PM, Rainer Jung wrote: On 21.10.2010 20:50, Mladen Turk wrote: OK? OK :) Let's put this to the end. Peace. I hope it works now as expected. Do you have anything to add to the changelog? Regards, Rainer

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 10/21/2010 09:16 PM, Rainer Jung wrote: On 21.10.2010 20:50, Mladen Turk wrote: OK? OK :) Let's put this to the end. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Rainer Jung
On 21.10.2010 20:50, Mladen Turk wrote: On 21/10/2010 20:33, Rainer Jung wrote: On 21.10.2010 19:12, Mladen Turk wrote: It means that we won't have jk-1.2.31 but jk-1.2.31-rSomething even for a release? You mean "It means we won't have?" or "It means we will have?" Guess it's a typo. Well

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 21/10/2010 20:36, Rainer Jung wrote: On 21.10.2010 20:01, Mladen Turk wrote: On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung -#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT +#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT JK_REVISION Ok, it seems I have to do it offici

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 21/10/2010 20:33, Rainer Jung wrote: On 21.10.2010 19:12, Mladen Turk wrote: It means that we won't have jk-1.2.31 but jk-1.2.31-rSomething even for a release? You mean "It means we won't have?" or "It means we will have?" Guess it's a typo. Well, I meant we wont have just mod_jk-1.2.3

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Rainer Jung
On 21.10.2010 20:01, Mladen Turk wrote: On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung -#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT +#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT JK_REVISION Ok, it seems I have to do it officially, so here it is: -1 veto Please rever

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Rainer Jung
On 21.10.2010 19:12, Mladen Turk wrote: On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung /* Source Control Revision as a suffix, e.g. "-r12345" */ -#define JK_REVISION "" +#define JK_REVISION "$Revision$" /** END OF AREA TO MODIFY BEFORE RELEASING */ @@ -65

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung -#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT +#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT JK_REVISION Ok, it seems I have to do it officially, so here it is: -1 veto Please revert adding this to the exposed version. (or a

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung /* Source Control Revision as a suffix, e.g. "-r12345" */ -#define JK_REVISION "" +#define JK_REVISION "$Revision$" /** END OF AREA TO MODIFY BEFORE RELEASING */ @@ -65,7 +65,7 @@ #if (JK_VERRC != 0) #