Just in case it was missed, here is the pull request I generated:
https://github.com/apache/tomcat/pull/4
Happy to talk about individual changes either in the comments there or here.
cheers
On 27 February 2014 09:24, Greg Wilkins wrote:
>
> On 25 February 2014 17:04, Violeta Georgieva wrot
On 25 February 2014 17:04, Violeta Georgieva wrote:
> We should be very careful when adding the OSGi meta data to the tomcat
> artifacts. Something that is stopping me from adding it right now, is that
> the different projects add different OSGi meta data specific to the
> concrete project. For e
Hi Greg,
2014-02-24 3:55 GMT+02:00 Greg Wilkins :
>
> On Jun 26, 2013, at 05:44:23 GMT Jeremy Boynes wrote:
>
> > I have been thinking about improvements to Jasper as well around better
support for Servlet
> > 3.0 concepts. One area would be decoupling it from Tomcat,
bootstrapping using an SCI
> From: Greg Wilkins [mailto:gr...@intalio.com]
> Subject: Re: Jasper Improvements
> isn't there a golden rule that no problem cannot be solved
> without another layer of delegation?
David Wheeler: "All problems in computer science can be solved by another level
of indire
On 24 February 2014 22:48, Mark Thomas wrote:
> On 24/02/2014 02:10, Greg Wilkins wrote:
> > The Jetty project has been considering switching to directly consume the
> > apache version of Jasper JSP.
> That said, there is a balance to be struck. If the changes are very
> invasive or impact perfor
On Feb 23, 2014, at 5:55 PM, Greg Wilkins wrote:
> On Jun 26, 2013, at 05:44:23 GMT Jeremy Boynes wrote:
>
>> I have been thinking about improvements to Jasper as well around better
>> support for Servlet
>> 3.0 concepts. One area would be decoupling it from Tomcat, bootstrapping
>> using an
On 24/02/2014 02:10, Greg Wilkins wrote:
> On Jun 26, 2013, at 05:44:23 GMT Jeremy Boynes wrote:
>
>> I have been thinking about improvements to Jasper as well around better
>> support for Servlet
>> 3.0 concepts. One area would be decoupling it from Tomcat, bootstrapping
>> using an SCI as hin
On Jun 26, 2013, at 05:44:23 GMT Jeremy Boynes wrote:
> I have been thinking about improvements to Jasper as well around better
> support for Servlet
> 3.0 concepts. One area would be decoupling it from Tomcat, bootstrapping
> using an SCI as hinted
> in ContextConfig. I'd also be interested in
On Jun 26, 2013, at 05:44:23 GMT Jeremy Boynes wrote:
> I have been thinking about improvements to Jasper as well around better
> support for Servlet
> 3.0 concepts. One area would be decoupling it from Tomcat, bootstrapping
> using an SCI as hinted
> in ContextConfig. I'd also be interested in
On Aug 12, 2013, at 8:40 AM, Mark Thomas wrote:
> On 12/08/2013 16:20, Jeremy Boynes wrote:
>
> I'm wondering about adding enableWebSockets() and enableJSPs() methods
> to Tomcat which would automatically add the relevant SCI to any Context
> created via one of the addContext(...) methods. Thoug
2013/8/12 Mark Thomas wrote:
>
>
> I'm wondering about adding enableWebSockets() and enableJSPs() methods
> to Tomcat which would automatically add the relevant SCI to any Context
> created via one of the addContext(...) methods. Thoughts?
>
+1
On 12/08/2013 16:20, Jeremy Boynes wrote:
> On Aug 12, 2013, at 7:46 AM, Mark Thomas wrote:
>
>> On 10/08/2013 23:20, Jeremy Boynes wrote:
>>> On Jul 22, 2013, at 10:10 AM, Mark Thomas
>>> wrote:
>>>
On 21/07/2013 18:36, Jeremy Boynes wrote: ...
> In the meantime, I'm going to look at
On Aug 12, 2013, at 7:46 AM, Mark Thomas wrote:
> On 10/08/2013 23:20, Jeremy Boynes wrote:
>> On Jul 22, 2013, at 10:10 AM, Mark Thomas wrote:
>>
>>> On 21/07/2013 18:36, Jeremy Boynes wrote:
>>> ...
In the meantime, I'm going to look at refactoring the TLD support as
described above
On 10/08/2013 23:20, Jeremy Boynes wrote:
> On Jul 22, 2013, at 10:10 AM, Mark Thomas wrote:
>
>> On 21/07/2013 18:36, Jeremy Boynes wrote:
>> ...
>>> In the meantime, I'm going to look at refactoring the TLD support as
>>> described above.
>>
>> Nice. See my note about TLD processing in the TOMC
On Jul 22, 2013, at 10:10 AM, Mark Thomas wrote:
> On 21/07/2013 18:36, Jeremy Boynes wrote:
> ...
>> In the meantime, I'm going to look at refactoring the TLD support as
>> described above.
>
> Nice. See my note about TLD processing in the TOMCAT-NEXT.txt file in
> the root on trunk.
I've take
Jeremy,
A little late returning to the party...
On 7/8/13 1:38 AM, Jeremy Boynes wrote:
> Finally, Jasper parses these documents first into DOM and the into
> its own version based on TreeNode (this is separate from the parse
> tree used for actual JSPs). Jasper already depends on tomcat-util for
On 21/07/2013 18:36, Jeremy Boynes wrote:
> With r1505235 JspC is now merging in from web fragments.
> It is still not handling resources found in those jars e.g. if they
> are referenced by an include directive or from a prelude/coda
> configuration.
It also needs to compile any JSPs found as t
On Jul 8, 2013, at 12:23 AM, Mark Thomas wrote:
> On 08/07/2013 06:38, Jeremy Boynes wrote:
>>
>> Another area of convergence is in parsing TLDs: currently both
>> Catalina and Jasper do it, differently.
>
> A lot of the code is identical with large comments to keep the two
> implementations in
On Jul 8, 2013, at 2:32 PM, Mark Thomas wrote:
> On 08/07/2013 16:02, Jeremy Boynes wrote:
>> On Jul 8, 2013, at 12:23 AM, Mark Thomas wrote:
>>> On 08/07/2013 06:38, Jeremy Boynes wrote:
>> ...
>>>
I'm planning on merging these two patches and pressing on with a
converged solution, b
On 08/07/2013 16:02, Jeremy Boynes wrote:
> On Jul 8, 2013, at 12:23 AM, Mark Thomas wrote:
>> On 08/07/2013 06:38, Jeremy Boynes wrote:
> ...
>>
>>> I'm planning on merging these two patches and pressing on with a
>>> converged solution, but probably won't be able to do much until next
>>> weeken
On 08/07/2013 16:55, Violeta Georgieva wrote:
> 2013/7/8 Mark Thomas wrote:
>>
>> On 08/07/2013 06:38, Jeremy Boynes wrote:
>>> On Jun 25, 2013, at 10:44 PM, Jeremy Boynes
>>> wrote:
>>
>>> Jasper's descriptor parser (used for web.xml and TLDs) can only
>>> validate DTD-based documents. I opened 5
2013/7/8 Mark Thomas wrote:
>
> On 08/07/2013 06:38, Jeremy Boynes wrote:
> > On Jun 25, 2013, at 10:44 PM, Jeremy Boynes
> > wrote:
>
> > Jasper's descriptor parser (used for web.xml and TLDs) can only
> > validate DTD-based documents. I opened 55212 about adding it. Such a
> > fix could benefit
On Jul 8, 2013, at 12:23 AM, Mark Thomas wrote:
> On 08/07/2013 06:38, Jeremy Boynes wrote:
...
>
>> I'm planning on merging these two patches and pressing on with a
>> converged solution, but probably won't be able to do much until next
>> weekend.
>
> I very much doubt that a single patch that
On 08/07/2013 06:38, Jeremy Boynes wrote:
> On Jun 25, 2013, at 10:44 PM, Jeremy Boynes
> wrote:
>
>> I have been thinking about improvements to Jasper as well around
>> better support for Servlet 3.0 concepts. One area would be
>> decoupling it from Tomcat, bootstrapping using an SCI as hinted i
On Jun 25, 2013, at 10:44 PM, Jeremy Boynes wrote:
> I have been thinking about improvements to Jasper as well around better
> support for Servlet 3.0 concepts. One area would be decoupling it from
> Tomcat, bootstrapping using an SCI as hinted in ContextConfig. I'd also be
> interested in imp
On Jun 26, 2013, at 12:58 PM, Christopher Schultz
wrote:
> On 6/26/13 2:57 PM, Jeremy Boynes wrote:
>>
>> You wrote in the bug that "annotation's don't make sense" - could you
>> clarify that?
>
> Yes: I was thinking that generating classes that used annotations would
> be a good idea. In retro
On Jun 26, 2013, at 12:10 PM, Nick Williams
wrote:
>
> On Jun 26, 2013, at 1:57 PM, Jeremy Boynes wrote:
>
>> On Jun 26, 2013, at 7:49 AM, Christopher Schultz
>> wrote:
>>
>>> Jeremy,
>>>
>>> On 6/26/13 1:44 AM, Jeremy Boynes wrote:
On Jun 11, 2013, at 1:50 PM, Nick Williams
wro
Jeremy,
On 6/26/13 2:57 PM, Jeremy Boynes wrote:
> On Jun 26, 2013, at 7:49 AM, Christopher Schultz
> wrote:
>
>> Jeremy,
>>
>> On 6/26/13 1:44 AM, Jeremy Boynes wrote:
>>> On Jun 11, 2013, at 1:50 PM, Nick Williams
>>> wrote:
Okay. One of many reasons I ask is that I still have it o
On Jun 26, 2013, at 1:57 PM, Jeremy Boynes wrote:
> On Jun 26, 2013, at 7:49 AM, Christopher Schultz
> wrote:
>
>> Jeremy,
>>
>> On 6/26/13 1:44 AM, Jeremy Boynes wrote:
>>> On Jun 11, 2013, at 1:50 PM, Nick Williams
>>> wrote:
Okay. One of many reasons I ask is that I still have
On Jun 26, 2013, at 7:49 AM, Christopher Schultz
wrote:
> Jeremy,
>
> On 6/26/13 1:44 AM, Jeremy Boynes wrote:
>> On Jun 11, 2013, at 1:50 PM, Nick Williams
>> wrote:
>>>
>>> Okay. One of many reasons I ask is that I still have it on my to-do
>>> to make some improvements on the JSP compiler
Jeremy,
On 6/26/13 1:44 AM, Jeremy Boynes wrote:
> On Jun 11, 2013, at 1:50 PM, Nick Williams
> wrote:
>>
>> Okay. One of many reasons I ask is that I still have it on my to-do
>> to make some improvements on the JSP compiler to support things
>> like 1) precompiling all JSPs on deploy and 2) a
31 matches
Mail list logo
