On 08/07/2013 16:55, Violeta Georgieva wrote: > 2013/7/8 Mark Thomas wrote: >> >> On 08/07/2013 06:38, Jeremy Boynes wrote: >>> On Jun 25, 2013, at 10:44 PM, Jeremy Boynes <jboy...@apache.org> >>> wrote: >> >>> Jasper's descriptor parser (used for web.xml and TLDs) can only >>> validate DTD-based documents. I opened 55212 about adding it. Such a >>> fix could benefit from using the same resolver and cached copies that >>> Catalina does. This is less of an issue if Jasper uses the >>> ServletContext as it could rely on the container to parse/validate >>> web.xml. It would still be needed if we wanted JspC to validate files >>> standalone but there is a separate ant task that can do that. >> >> Jasper and Catalina need to share the same web.xml parsing and merging >> code. Violetta started on this before she was a committer but the work >> stalled primarily because of the size of patch which in turn was due to >> the re-factoring required. The first step is to get the parsing and >> merging into a package that can be shared by Jasper and Catalina. That >> is far easier for a committer to do as they can use the refactoring >> tools in an IDE rather than having to generate a huge patch and then >> wait for a committer to find the time to review it. >> > > > Jeremy, > > Here [1] is my work on the topic that I started several months ago. > We can discuss which parts of it are still applicable and I can work on > this also. > > Regards > Violeta > > [1] https://github.com/violetagg/apache-tomcat-8.0/commits/master
Yep, that is where I was planning on starting from as well - at least following the same steps anyway. There may well be differences in the detail. One of the things I want to do is to take a look with Structure 101 to ensure that we get the interdependencies right. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
