Re: Improving memory efficiency

2005-12-20 Thread Remy Maucherat
Costin Manolache wrote: Assuming that most of the pages use 'huge' buffers - you're right. However, if you have few pages that need large buffers - and most don't - this will help. And you would pay the price of System.arraycopy on the bad pages - i.e. normal pages will be faster, and jsps that

Re: Improving memory efficiency

2005-12-19 Thread Costin Manolache
On 12/19/05, Remy Maucherat <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > > One of the problems is that jasper is a tricky piece of code, and > > usually reducing memory this way can have unexpected impact. Maybe a > > more 'moderate' approach would be more acceptable, like checking the >

Re: Improving memory efficiency

2005-12-19 Thread Remy Maucherat
Costin Manolache wrote: One of the problems is that jasper is a tricky piece of code, and usually reducing memory this way can have unexpected impact. Maybe a more 'moderate' approach would be more acceptable, like checking the size of the buffers, and only reset it if it is indeed 'huge'. This w

Re: Improving memory efficiency

2005-12-19 Thread Remy Maucherat
Tino Schwarze wrote: Hi Costin, On Sun, Dec 18, 2005 at 10:01:08AM -0800, Costin Manolache wrote: One of the problems is that jasper is a tricky piece of code, and usually reducing memory this way can have unexpected impact. Maybe a more 'moderate' approach would be more acceptable, like chec

Re: Improving memory efficiency

2005-12-18 Thread Tino Schwarze
Hi Costin, On Sun, Dec 18, 2005 at 10:01:08AM -0800, Costin Manolache wrote: > One of the problems is that jasper is a tricky piece of code, and > usually reducing memory this way can have unexpected impact. Maybe a > more 'moderate' approach would be more acceptable, like checking the > size of

Re: Improving memory efficiency

2005-12-18 Thread Costin Manolache
One of the problems is that jasper is a tricky piece of code, and usually reducing memory this way can have unexpected impact. Maybe a more 'moderate' approach would be more acceptable, like checking the size of the buffers, and only reset it if it is indeed 'huge'. This would take care of the wors

RE: Improving memory efficiency

2005-12-18 Thread Carl Olivier
- From: Tino Schwarze [mailto:[EMAIL PROTECTED] Sent: 18 December 2005 16:59 To: dev@tomcat.apache.org Subject: Re: Improving memory efficiency On Sun, Dec 18, 2005 at 05:02:39PM +0100, Remy Maucherat wrote: > >What do you think about this issue? > > It's a fine solution for your &qu

Re: Improving memory efficiency

2005-12-18 Thread Tino Schwarze
On Sun, Dec 18, 2005 at 05:02:39PM +0100, Remy Maucherat wrote: > >What do you think about this issue? > > It's a fine solution for your "problem", I suppose. Thanks for the > patch, but we are not going to use it. So could you please give me a hint, why you are not going to use it? My "problem

Re: Improving memory efficiency

2005-12-18 Thread Remy Maucherat
Tino Schwarze wrote: What do you think about this issue? It's a fine solution for your "problem", I suppose. Thanks for the patch, but we are not going to use it. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additio