On 17 November 2010 07:07, Jeremy Boynes wrote:
> For a one-time reformat I'd probably go with the one in IDEA followed by
> manual review for where it messed up line breaks etc.
>
> For ongoing checks, we could add a checkstyle report to the build using the
> same ruleset as Tomcat (or a strict
On 17 November 2010 03:45, Rex Wang wrote:
> What's the formatter you plan to use? Is it public and other committer
> obeyed? Otherwise, it will mess up again in future..
>
> Anyway, +1 for tab replacement with 4 spaces.
The current code asumes tabs consume 8 spaces, at least in the example
code
For a one-time reformat I'd probably go with the one in IDEA followed by manual
review for where it messed up line breaks etc.
For ongoing checks, we could add a checkstyle report to the build using the
same ruleset as Tomcat (or a stricter subset if desired).
The results would look something l
+1 for reformatting.
I've lived with the terrible code style in taglibs for years because I
felt that reformatting it just for me was over the top. Now there are
more eyes on the code; PLEASE MAKE IT READABLE! :)
I'm assuming it's a one-time only reformat to get us onto something sane.
Hen
On T
What's the formatter you plan to use? Is it public and other committer
obeyed? Otherwise, it will mess up again in future..
Anyway, +1 for tab replacement with 4 spaces.
-Rex
2010/11/16 Jeremy Boynes
> As well as the tabs, there are broader inconsistencies in the style (e.g.
> consistent brace
On 16 November 2010 15:38, Jeremy Boynes wrote:
> As well as the tabs, there are broader inconsistencies in the style (e.g.
> consistent braces, missing javadoc, and the like) that lead to IDE warnings.
>
> How about running everything through a re-formatter to clean this up?
> Downside is that
