On 16 November 2010 15:38, Jeremy Boynes <jboy...@apache.org> wrote: > As well as the tabs, there are broader inconsistencies in the style (e.g. > consistent braces, missing javadoc, and the like) that lead to IDE warnings. > > How about running everything through a re-formatter to clean this up? > Downside is that it will make back-patching harder. > +1 from me.
I have had bad experiences with auto code formatting. It tends to mess up comments. Or cause line -breaks in silly places. Not sure you would gain much compared with the downsides. However, tabs are a particular problem, because there is no standard setting (both 4 and 8 are common). The wrong setting makes it harder to read the code. > On Nov 16, 2010, at 5:28 AM, bugzi...@apache.org wrote: > >> https://issues.apache.org/bugzilla/show_bug.cgi?id=50279 >> >> Summary: Tab police >> Product: Taglibs >> Version: unspecified >> Platform: PC >> OS/Version: Windows XP >> Status: NEW >> Severity: normal >> Priority: P2 >> Component: Unknown Taglib >> AssignedTo: dev@tomcat.apache.org >> ReportedBy: s...@apache.org >> >> >> Created an attachment (id=26301) >> --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26301) >> Fix tabs in examples code >> >> There are oodles of tabs in the Taglibs code. >> >> Tabs seem to be set at 8 spaces, at least in the examples section. >> >> I can provide patches for the other code if required. >> >> -- >> Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email >> ------- You are receiving this mail because: ------- >> You are the assignee for the bug. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
