Re: [taglibs] Null handling in Functions

2010-07-06 Thread Jeremy Boynes
IMO they would not help either users or developers much as this is not an contract used by anyone other than the container. They would supplement the documentation but we would still want that to explain why a null would not be passed. What environment to support deserves its own thread :) On

Re: [taglibs] Null handling in Functions

2010-07-06 Thread Henri Yandell
With Tomcat 7 now out, it's tempting to focus on Taglibs in that space rather than worrying about JavaEE5. Does it do much for the user to add the annotations? Does it do much for us on the development side? On Mon, Jul 5, 2010 at 12:17 AM, Jeremy Boynes wrote: > I work on a patch to remove them

Re: [taglibs] Null handling in Functions

2010-07-05 Thread Jeremy Boynes
I work on a patch to remove them and add JavaDoc. What do you think of adding JSR-303 javax.validation annotations like NotNull? Those are part of JavaEE 6 so are guaranteed to be available there but would require a dependency for a JavaEE5 environment. My thought would be not to use them yet.

Re: [taglibs] Null handling in Functions

2010-07-04 Thread Henri Yandell
Agreed on 1.18.2. For String params (and Number, Character and Boolean) it looks like Functions should be able to assume that they're null-safe. Hen On Sun, Jul 4, 2010 at 12:20 PM, Jeremy Boynes wrote: > Different methods in our Functions implementation handle null parameters > inconsistently;