Agreed on 1.18.2. For String params (and Number, Character and Boolean) it looks like Functions should be able to assume that they're null-safe.
Hen On Sun, Jul 4, 2010 at 12:20 PM, Jeremy Boynes <jboy...@apache.org> wrote: > Different methods in our Functions implementation handle null parameters > inconsistently; for example, toUpperCase does not perform any null check > whereas indexOf does. If I grok the EL spec correctly, all String parameter > values should be coerced by the rules in 1.18.2 which would guarantee that > nulls are converted to "" and hence the null checks in the implementation are > redundant. I confirmed that the EL implementation in Tomcat 7 [1] does this. > > My thought would be to remove them and rely on the JSP Engine to coerce > correctly. If this isn't safe then we should add similar checks to the other > methods. > > Thoughts? > Thanks > Jeremy > > [1] > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ELSupport.java?view=markup#l405 > called from AstFunction#getValue > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
