Re: [LOBBYING] Add nio connector to configuration validation

2007-10-20 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: -0 this isn't a new proposal, the implementation has already been done. this is just completing it. we'd have to go back to when the implementation was done to start changing it, that's not what I'm doing. Filip The setProperty was done way before JMX, and it's qui

Re: [LOBBYING] Add nio connector to configuration validation

2007-10-19 Thread Costin Manolache
-0 The setProperty was done way before JMX, and it's quite hacky. I think standardising on JMX-like model is better - i.e. if we make changes to setProperty and connector configuration, it should bring it closer to JMX. In JMX we have a "void setAttribute(...) throws AttributeNotFound", plus a m

Re: [LOBBYING] Add nio connector to configuration validation

2007-10-19 Thread Tim Funk
For java/org/apache/coyote/http11/Http11NioProtocol.java Is it me or does this look odd after the patch (as well as before) ... public void setProperty(String name, String value) { setAttribute(name, value); if (/*omitted for word wrap since it doesn't matter */) { return ep.setPr

Re: [LOBBYING] Add nio connector to configuration validation

2007-10-19 Thread Paul Shemansky
For what it's worth :) +1 On 10/19/07, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > Ok, sending a little email to lobby for a useful change. To the contrary > of comments and vetoes to this change, it doesn't change existing > behavior, it simplifies it, and also adds the NIO connector to