Re: Performance change

2015-01-12 Thread Rémy Maucherat
2015-01-11 20:40 GMT+01:00 Mark Thomas : > Just for info, I have found that none of the non-blocking IO (including > that used by the WebSocket impl) was using the socket write buffer. I'm > making good progress refactoring things so everything is buffered by > default but it has triggered a lot o

Re: Performance change

2015-01-11 Thread Mark Thomas
On 09/01/2015 23:57, Rémy Maucherat wrote: > 2015-01-09 22:44 GMT+01:00 Mark Thomas : > >>> I made a mistake, which also made me think that the NIO connector didn't >>> suffer from the NPE. In the end, there's no significant improvement >> there. >> >> That matches my results. NIO is about the sam

Re: Performance change

2015-01-09 Thread Rémy Maucherat
2015-01-09 22:44 GMT+01:00 Mark Thomas : > > I made a mistake, which also made me think that the NIO connector didn't > > suffer from the NPE. In the end, there's no significant improvement > there. > > That matches my results. NIO is about the same in 8.0.x and 9.0.x for me. > > >> The other thin

Re: Performance change

2015-01-09 Thread Mark Thomas
On 09/01/2015 19:13, Rémy Maucherat wrote: > 2015-01-09 18:45 GMT+01:00 Mark Thomas : > >> One reason (once all the refactoring is complete) might be WebSocket >> since the use of CompletionHandlers in WebSocket and NIO2 may allow for >> some efficiencies that just aren't possible with NIO or APR.

Re: Performance change

2015-01-09 Thread Rémy Maucherat
2015-01-09 18:45 GMT+01:00 Mark Thomas : > One reason (once all the refactoring is complete) might be WebSocket > since the use of CompletionHandlers in WebSocket and NIO2 may allow for > some efficiencies that just aren't possible with NIO or APR. > We'll see. > > I'll add looking at this to my

Re: Performance change

2015-01-09 Thread Mark Thomas
On 09/01/2015 17:25, Rémy Maucherat wrote: > Hi, > > Following the refactoring, performance is significantly down for NIO2, but > improved for NIO1. > > With my ab test on tomcat.gif, logging disabled, this does (Tomcat 8 vs > trunk): > NIO1: 50k -> 60k up 20% wow > NIO2: 65k -> 57k down 15% :

Performance change

2015-01-09 Thread Rémy Maucherat
Hi, Following the refactoring, performance is significantly down for NIO2, but improved for NIO1. With my ab test on tomcat.gif, logging disabled, this does (Tomcat 8 vs trunk): NIO1: 50k -> 60k NIO2: 65k -> 57k IMO the difference is significant, so this is a real regression. I didn't really see