2015-01-11 20:40 GMT+01:00 Mark Thomas <ma...@apache.org>: > Just for info, I have found that none of the non-blocking IO (including > that used by the WebSocket impl) was using the socket write buffer. I'm > making good progress refactoring things so everything is buffered by > default but it has triggered a lot of bugs that need fixing by inserting > a ServletOutputStream.flush() at an appropriate point. >
Yes, I noted some months ago that upgrade wasn't buffered, but it is not necessarily a bug. Obviously buffering isn't going to hurt since the bytes would be copied anyway. > > This might turn into something that causes apps issues (if indeed any > apps at all are using the HTTP upgrade API). If this is the case we can > add an option to always flush an upgraded OutputStream after a write but > for now I plan to leave this as a TODO. > > My impressions of performance so far is good but I want to do some side > by side comparisons of 8.0.x vs 9.0.x for various cases once I have the > refactoring complete to see what the real differences are. If it turns > out to be positive, I may see if I can structure an ApacheCon talk out > of it. > > APR and NIO2 are now the same as in 8.x in my toy "benchamrk", and NIO is still up. I doubt this makes any real world difference though, it's just a quick check. Rémy
