New unit tests for Authenticators and SingleSignOn

2012-02-29 Thread Brian Burch
I have finished the third in my series of new unit tests, which examines the SingleSignOn interactions between the Digest and NonLogin Authenticators. Because each Authenticator class has its own SSO logic, I feel it is sensible to test that logic explicitly. However, there is no need to duplic

Re: New unit tests for Authenticators and SingleSignOn

2012-01-24 Thread Mark Thomas
On 23/01/2012 06:06, Brian Burch wrote: > I have now finished the second in my set of new unit test classes. This > one examines the SingleSignOn interactions between the NonLogin and > Basic Authenticators. > > It is consistent with the various changes made to my previously > submitted test class

Re: New unit tests for Authenticators and SingleSignOn

2012-01-22 Thread Brian Burch
I have now finished the second in my set of new unit test classes. This one examines the SingleSignOn interactions between the NonLogin and Basic Authenticators. It is consistent with the various changes made to my previously submitted test class, org.apache.catalina.authenticator.TestNonLogi

Re: New unit tests for Authenticators and SingleSignOn

2012-01-14 Thread Brian Burch
On 15/01/12 04:16, Mark Thomas wrote: On 14/01/2012 08:24, Brian Burch wrote: I realise everyone will be busy on the 7.0.24 release, so don't let this distract you - it isn't urgent. I had to fix a failing unit test so it was no bother. Thanks very much, Mark. I've added this to trunk and

Re: New unit tests for Authenticators and SingleSignOn

2012-01-14 Thread Mark Thomas
On 14/01/2012 08:24, Brian Burch wrote: > I realise everyone will be busy on the 7.0.24 release, so don't let this > distract you - it isn't urgent. I had to fix a failing unit test so it was no bother. I've added this to trunk and will port it to 7.0.x once I have taken a closer look at it. The

New unit tests for Authenticators and SingleSignOn

2012-01-14 Thread Brian Burch
I realise everyone will be busy on the 7.0.24 release, so don't let this distract you - it isn't urgent. Before I started developing my unit tests for SSO, I wrote a test class for NonLoginAuthenticator and BasicAuthenticator. This test class checks the behaviour of both authenticators when th