Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

On 27/11/2019 17:07, Rémy Maucherat wrote: > On Wed, Nov 27, 2019 at 5:35 PM Mark Thomas My preference for writing earlier is only a slight one. I'm more > concerned that different methods take a different approach. Taking a > closer look at that is on my TODO list but it isn't a prior

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

On Wed, Nov 27, 2019 at 5:35 PM Mark Thomas wrote: > On 27/11/2019 15:59, Rémy Maucherat wrote: > > On Wed, Nov 27, 2019 at 4:51 PM Mark Thomas > > wrote: > > > > I've been looking at the 9.0.x changes. > > > > What is clearer now (I think the differences were al

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

On 27/11/2019 15:59, Rémy Maucherat wrote: > On Wed, Nov 27, 2019 at 4:51 PM Mark Thomas > wrote: > > I've been looking at the 9.0.x changes. > > What is clearer now (I think the differences were always there - just > harder to see with the more complex code)

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

On Wed, Nov 27, 2019 at 4:51 PM Mark Thomas wrote: > I've been looking at the 9.0.x changes. > > What is clearer now (I think the differences were always there - just > harder to see with the more complex code) is that there are some minor > differences in behaviour when all of the following are

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

This one, also the easiest one: drop > SocketWrapperBase.write(Non)BlockingDirect methods > > > Done. I've been looking at the 9.0.x changes. What is clearer now (I think the differences were always there - just harder to see with the more complex code) is that there are some minor differ

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

On Tue, Nov 26, 2019 at 2:36 PM Rémy Maucherat wrote: > It looked ok and removed a big chunk of code so I went ahead with it. > Status update: > - This one, also the easiest one: drop > SocketWrapperBase.write(Non)BlockingDirect methods > Done. Updated port list: - Remove m

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

ould be > able to handle that. > It looked ok and removed a big chunk of code so I went ahead with it. As far as porting goes, I have: - This one, also the easiest one: drop SocketWrapperBase.write(Non)BlockingDirect methods - Move the processor tracking to the wrapper and the connection map t

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

On 22/11/2019 15:25, Rémy Maucherat wrote: > Hi, > > I'm looking at the endpoint code a lot in preparation for ports to 8.5. > > I noticed the write(Non)BlockingDirect methods in particular as they had > a fixme which wondered about the buffering strategy. Given the use, the > thinking seems very

Drop SocketWrapperBase.write(Non)BlockingDirect methods

Hi, I'm looking at the endpoint code a lot in preparation for ports to 8.5. I noticed the write(Non)BlockingDirect methods in particular as they had a fixme which wondered about the buffering strategy. Given the use, the thinking seems very legacy optimization oriented, because: - If the socket b