https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #27 from Filip Hanik 2011-05-04 15:20:13 UTC ---
Please stop posting new code to this bug. This bug has been closed and marked
fixed as per the original bug.
Open a new bug for new bugs/features/enhancements
--
Configure bugma
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #26 from Filip Hanik 2011-05-04 15:19:09 UTC ---
(In reply to comment #25)
> Created attachment 26955 [details]
> Updated [again] example implementation for Jdbc4 Validator
>
> Minor tweak to reflect on the implementation class
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
Glen Taylor changed:
What|Removed |Added
Attachment #26948|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #24 from Filip Hanik 2011-05-02 19:20:37 UTC ---
Now you're confusing me, why would a validator be an interceptor?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
Glen Taylor changed:
What|Removed |Added
Attachment #26944|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #22 from Filip Hanik 2011-05-02 17:16:47 UTC ---
Patch added to r1098667
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assigne
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #21 from Glen Taylor 2011-05-02 16:53:57 UTC ---
Created attachment 26947
--> https://issues.apache.org/bugzilla/attachment.cgi?id=26947
Patch ConnectionPool.java to apply JdbcInterceptor properties before calling
JdbcIntercep
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #20 from Glen Taylor 2011-04-29 23:13:43 UTC ---
To be clear, please note that the example in #19 will NOT function correctly
due to the issues discussed in #18. It was just to clarify the workaround I
was attempting.
Thanks f
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #19 from Glen Taylor 2011-04-29 23:01:59 UTC ---
Created attachment 26944
--> https://issues.apache.org/bugzilla/attachment.cgi?id=26944
Example JDBC4 Validator/JdbcInjector implementation
See my previous comment on this bug
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #18 from Glen Taylor 2011-04-29 23:00:03 UTC ---
Gah! To my previous comment (#15), I wired up a Validator class which also
extends JdbcInterceptor (I'll attach separately). Since ConnectionPool.init()
instantiates each define
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #17 from Filip Hanik 2011-04-29 17:47:17 UTC ---
I added this in r1097895
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assign
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #16 from Filip Hanik 2011-04-29 16:45:35 UTC ---
I agree, I will add the setValidator method
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #15 from Glen Taylor 2011-04-29 16:35:06 UTC ---
May I ask why no provision was made for _configuring_ the Validator? I love
the pluggable validation approach, but even the JDBC4 isValid() scenario has a
configurable element (t
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #13 from Matt Passell 2010-08-06
15:17:58 EDT ---
Created an attachment (id=25858)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25858)
Add description for validatorClassName attribute to doc
Great! I've attached
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #12 from Mark Thomas 2010-08-05 18:31:28 EDT ---
Looks good to me. Patch applied. Many thanks.
Any chance of a patch for the docs?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You a
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
Matt Passell changed:
What|Removed |Added
Attachment #25398|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
Matt Passell changed:
What|Removed |Added
Attachment #25439|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
Mark Thomas changed:
What|Removed |Added
Component|Modules: jdbc-pool |jdbc-pool
Product|Tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #10 from Mark Thomas 2010-07-02 14:10:42 EDT ---
(In reply to comment #9)
> Any feedback on my second patch? I've been using it in production for more
> than a month now with no obvious issues. I realize that you guys are prob
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #9 from Matt Passell 2010-07-01
11:41:13 EDT ---
Any feedback on my second patch? I've been using it in production for more
than a month now with no obvious issues. I realize that you guys are probably
busy getting Tomcat 7 r
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #8 from Filip Hanik 2010-05-16 00:43:03 EDT ---
Don't bother with isClosed, that is a simple flag that most drivers implement
to return true if and only if close() has been called. It has really nothing to
do with the underlying
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #7 from Matt Passell 2010-05-14
11:49:20 EDT ---
Created an attachment (id=25439)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25439)
Add Validator interface and references to it where appropriate
Here's an alter
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #6 from Matt Passell 2010-05-12
12:12:21 EDT ---
(In reply to comment #5)
Thanks Mark. Those were reasonable points. I'll respond to each.
> It appears that this patch forces validation to happen even if the user
> doesn't
>
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #5 from Mark Thomas 2010-05-12 06:47:44 EDT ---
I don't know the code that well so feel free to treat these comments with that
in mind.
In no particular order...
It appears that this patch forces validation to happen even if t
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #4 from Matt Passell 2010-05-04
12:28:00 EDT ---
Created an attachment (id=25398)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25398)
If no validation query is available, fall back on other approaches
This isn't
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #3 from Matt Passell 2010-04-29
19:32:27 EDT ---
(In reply to comment #2)
> > There should be plugaable Validator which could be configured in the
> > poolProperties. e.g
>
> why not just an interceptor if you want custom val
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #2 from Filip Hanik 2010-03-01 20:36:52 UTC ---
> There should be plugaable Validator which could be configured in the
> poolProperties. e.g
why not just an interceptor if you want custom validation?
> And for jdk1.6 we can h
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #1 from VickyKak 2010-02-26 05:23:56 UTC ---
public boolean validate(int validateAction) {
return validate(validateAction,null);
}
There should be plugaable Validator which could be configured in the
poolPropertie
29 matches
Mail list logo
