https://issues.apache.org/bugzilla/show_bug.cgi?id=48817
--- Comment #5 from Mark Thomas <ma...@apache.org> 2010-05-12 06:47:44 EDT --- I don't know the code that well so feel free to treat these comments with that in mind. In no particular order... It appears that this patch forces validation to happen even if the user doesn't want it. That could add a fair amount of overhead. I'd try isValid() before trying isClosed() The exception caught in tryIsValid() is rethrown and then silently swallowed. I can see why, but that code looks expensive. I'd probably check earlier to see if the method was available and set a flag I could check (cheaply) later. In terms of the issues with borrowConnection() and setupConnection() would it be feasible to check if setupConnection() fails and it if does, try borrowing a new connection? I assume that if borrowConnection() fails then getConnection() should fail. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
