https://bz.apache.org/bugzilla/show_bug.cgi?id=69504
--- Comment #4 from Chen Jp ---
see PR 821.
https://github.com/apache/tomcat/pull/821
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscri
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504
--- Comment #3 from Mark Thomas ---
If you want to propose a refactoring then please provide a patch for review.
--
You are receiving this mail because:
You are the assignee for the bug.
---
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504
--- Comment #2 from Chen Jp ---
propose extract recycling ops on external request/response from
CoyoteAdapter#log.
e.g. supposed implementation of CoyoteAdapter#checkRecycled: 1. access logging;
2. explicitly make sure req/resp were recycled
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504
Mark Thomas changed:
What|Removed |Added
OS||All
--- Comment #1 from Mark Thomas ---
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504
Bug ID: 69504
Summary: CoyoteAdapter recycle request/response objects in
"log()" method even if they are came from outside.
Product: Tomcat 10
Version: 10.1.34
markt-asf commented on issue #176: CoyoteAdapter: fix out-of-bounds read in
checkNormalize
URL: https://github.com/apache/tomcat/pull/176#issuecomment-507753421
Many thanks for raising this issue. I think we have tracked down the root
cause and fixed it. Note that 7.0.x was not affected
markt-asf closed pull request #176: CoyoteAdapter: fix out-of-bounds read in
checkNormalize
URL: https://github.com/apache/tomcat/pull/176
This is an automated message from the Apache Git Service.
To respond to the message
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299572216
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299500242
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11
alpire commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299503403
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11
alpire commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299498714
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299493101
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11
alpire commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299284882
##
File path: test/org/apache/catalina/connector/TestCoyoteAdapter.java
##
@@ -344,6 +345,29
alpire commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299276651
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11
alpire commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299276368
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1252,6 +1252,11
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Mark,
On 6/29/19 16:01, Mark Thomas wrote:
> On 29/06/2019 02:26, GitBox wrote:
>> alpire opened a new pull request #176: CoyoteAdapter: fix
>> out-of-bounds read in checkNormalize URL:
>> https://github.com/apache/tomcat/p
On 29/06/2019 21:01, Mark Thomas wrote:
> On 29/06/2019 02:26, GitBox wrote:
>> alpire opened a new pull request #176: CoyoteAdapter: fix out-of-bounds read
>> in checkNormalize
>> URL: https://github.com/apache/tomcat/pull/176
>>
>>
>>On malformed
On 29/06/2019 02:26, GitBox wrote:
> alpire opened a new pull request #176: CoyoteAdapter: fix out-of-bounds read
> in checkNormalize
> URL: https://github.com/apache/tomcat/pull/176
>
>
>On malformed requests, checkNormalize would throw an
> ArrayIndexOutOfBoundsE
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r298806534
##
File path: test/org/apache/catalina/connector/TestCoyoteAdapter.java
##
@@ -326,6 +326,7
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r298806436
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1252,6 +1252,11
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r298806528
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r298806623
##
File path: test/org/apache/catalina/connector/TestCoyoteAdapter.java
##
@@ -344,6 +345,29
alpire opened a new pull request #176: CoyoteAdapter: fix out-of-bounds read in
checkNormalize
URL: https://github.com/apache/tomcat/pull/176
On malformed requests, checkNormalize would throw an
ArrayIndexOutOfBoundsException leading to a 500 response. This change fixes
checkNormalize to
x27;re allowed to
> access public+protected+package-private members.
>
> Alexis
>
> 2016-01-31 15:34 GMT+01:00 Roel Storms :
>
> > Hello Tomcat Devs,
> >
> > I am looking at CoyoteAdapter and Request classes in the trunk of
> Tomcat8:
> >
> >
>
Hi Roel,
Both classes are in the same package. That means that they're allowed to
access public+protected+package-private members.
Alexis
2016-01-31 15:34 GMT+01:00 Roel Storms :
> Hello Tomcat Devs,
>
> I am looking at CoyoteAdapter and Request classes in the trunk of Tomcat
Hello Tomcat Devs,
I am looking at CoyoteAdapter and Request classes in the trunk of Tomcat8:
https://svn.apache.org/repos/asf/tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
https://svn.apache.org/repos/asf/tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector
> From: Mark Thomas [mailto:ma...@apache.org]
> Subject: Re: Tomcat exception in CoyoteAdapter
> >
> > > redirectPort="8080" scheme="http" secure="false"
. . .
> > > protocol="HTTP/1.1"/>
> With a better expla
On 29/11/2013 13:55, at.silk wrote:
> Hi,
>
> I'm a senior consultant and I contact you to talk about an exception
> that we receive in a Tomcat class.
>
> Few days ago we get an error in an application integrated with
> Tomcat. The exception is raised by Tomcat so a blank page is
> displayed in
Hi,
I'm a senior consultant and I contact you to talk about an exception that we
receive in a Tomcat class.
Few days ago we get an error in an application integrated with Tomcat. The
exception is raised by Tomcat so a blank page is displayed in our portal
application.
We have tried to get info
https://issues.apache.org/bugzilla/show_bug.cgi?id=51120
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
/connector/CoyoteAdapter.java
b/java/org/apache/catalina/connector/CoyoteAdapter.java
index de2f7d2..10fb3c5 100644
--- a/java/org/apache/catalina/connector/CoyoteAdapter.java
+++ b/java/org/apache/catalina/connector/CoyoteAdapter.java
@@ -271,7 +271,7 @@ public class CoyoteAdapter implements Adapter
https://issues.apache.org/bugzilla/show_bug.cgi?id=51120
--- Comment #1 from Saravanan 2011-04-27 03:39:20 EDT
---
I think this might help.
In the comet connection, when the client sends some data basically triggering
the read event, the NPE exception is not coming.
But if the client disconne
https://issues.apache.org/bugzilla/show_bug.cgi?id=51120
Summary: Nullpointer exception in CoyoteAdapter when the Client
disconnects the socket abruptly.
Product: Tomcat 7
Version: 7.0.12
Platform: PC
OS/Version: Windows XP
https://issues.apache.org/bugzilla/show_bug.cgi?id=50620
Konstantin Kolinko changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=50620
Mark Thomas changed:
What|Removed |Added
Component|Catalina|Catalina
Version|unspecif
https://issues.apache.org/bugzilla/show_bug.cgi?id=50620
--- Comment #1 from Mark Thomas 2011-01-20 13:36:30 EST ---
Thanks for the report.
Fixed in 7.0.x and will be in 7.0.7 onwards.
I used a slightly different patch but it does the same thing.
I have proposed a back-port of the fix for 6.0.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50620
Summary: Session related errors prevent clean recycle of
Request and Response objects by CoyoteAdapter
Product: Tomcat 6
Version: unspecified
Platform: All
OS/Version
37 matches
Mail list logo
