https://issues.apache.org/bugzilla/show_bug.cgi?id=51120
--- Comment #2 from Darryl Miles <dar...@darrylmiles.org> 2011-04-27 12:28:35 EDT --- Possible candidate, notice the if(ctxt != null) check in other code that does the same thing. From the 1st hunk in the patch. Line 320 (as shown in the patch - does not check context!=null) but was also recently added, might need audit. Line 430 (which was line 426 in user exception, plus the recent changes below applied - does not check context!=null) git clone https://github.com/apache/tomcat70.git git diff TOMCAT_7_0_12 diff --git a/java/org/apache/catalina/connector/CoyoteAdapter.java b/java/org/apache/catalina/connector/CoyoteAdapter.java index de2f7d2..10fb3c5 100644 --- a/java/org/apache/catalina/connector/CoyoteAdapter.java +++ b/java/org/apache/catalina/connector/CoyoteAdapter.java @@ -271,7 +271,7 @@ public class CoyoteAdapter implements Adapter { if (!request.isAsync() && !comet) { // Error or timeout - need to tell listeners the request is over // Have to test this first since state may change while in this - // method and this is only required if entering this methos in + // method and this is only required if entering this method in // this state Context ctxt = (Context) request.getMappingData().context; if (ctxt != null) { @@ -317,6 +317,10 @@ public class CoyoteAdapter implements Adapter { request.finishRequest(); response.finishResponse(); req.action(ActionCode.POST_REQUEST , null); + ((Context) request.getMappingData().context).logAccess( + request, response, + System.currentTimeMillis() - req.getStartTime(), + false); } } catch (IOException e) { -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
