Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-04 Thread Emmanuel Bourg
Le 04/12/2020 à 02:07, Igal Sapir a écrit : >> Shall we backport these commits to 9.x and 8.5? >> It will make it easier to backport future changes in these classes. > > +1 > > No need to diverge the branches unnecessarily. I've backported the changes to Tomcat 9 and 8.5 (minus the incompatible

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-04 Thread Emmanuel Bourg
Le 04/12/2020 à 13:31, Rémy Maucherat a écrit : > I mean you can add lambda expressions in Tomcat 9, but not Tomcat 8.5, > right ? Since Tomcat 8.5 is supposed to be Java 7 friendly ( > http://tomcat.apache.org/whichversion.html ). Tomcat 7 would be Java 6 > (ouch). Oh ok, I thought you were refe

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-04 Thread Rémy Maucherat
On Fri, Dec 4, 2020 at 1:04 PM Emmanuel Bourg wrote: > Le 04/12/2020 à 12:13, Rémy Maucherat a écrit : > > > +1 to backport to 9.0, but not to Tomcat 8.5 since it would need to be > Java > > 7 compatible [some of the changes might be fine, but for others it's not > > possible]. > > Did you mean T

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-04 Thread Emmanuel Bourg
Le 04/12/2020 à 12:13, Rémy Maucherat a écrit : > +1 to backport to 9.0, but not to Tomcat 8.5 since it would need to be Java > 7 compatible [some of the changes might be fine, but for others it's not > possible]. Did you mean Tomcat 7? Because Tomcat 8.5 already depends on Java 7. Emmanuel Bour

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-04 Thread Rémy Maucherat
On Fri, Dec 4, 2020 at 2:08 AM Igal Sapir wrote: > On Thu, Dec 3, 2020 at 2:48 PM Martin Grigorov > wrote: > > > Hi, > > > > Shall we backport these commits to 9.x and 8.5? > > It will make it easier to backport future changes in these classes. > > > > +1 > > No need to diverge the branches unne

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-03 Thread Igal Sapir
On Thu, Dec 3, 2020 at 2:48 PM Martin Grigorov wrote: > Hi, > > Shall we backport these commits to 9.x and 8.5? > It will make it easier to backport future changes in these classes. > +1 No need to diverge the branches unnecessarily. Igal > > Martin > > On Fri, Dec 4, 2020, 00:06 Emmanuel B

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-03 Thread Martin Grigorov
Hi, Shall we backport these commits to 9.x and 8.5? It will make it easier to backport future changes in these classes. Martin On Fri, Dec 4, 2020, 00:06 Emmanuel Bourg wrote: > Hi Christopher, > > Le 03/12/2020 à 21:49, Christopher Schultz a écrit : > > > I'm curious as to why this change is

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-03 Thread Emmanuel Bourg
Hi Christopher, Le 03/12/2020 à 21:49, Christopher Schultz a écrit : > I'm curious as to why this change is warranted. I'm not suggesting it's > not... just wondering what the benefit is? Avoiding a pass-through > method call? It's the shorter idiom to sort lists with Java 8+, it just improves t

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-03 Thread Christopher Schultz
Emmanuel, I'm curious as to why this change is warranted. I'm not suggesting it's not... just wondering what the benefit is? Avoiding a pass-through method call? Thanks, -chris On 12/1/20 19:40, ebo...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. eb

[tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-01 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 521b3a3e481ae121d5006124611a89a4c4a1302e Author: Emmanuel Bourg AuthorDate: Wed Dec 2 01:28:25 2020 +0100 Replace C