On Fri, Dec 4, 2020 at 2:08 AM Igal Sapir <i...@lucee.org> wrote: > On Thu, Dec 3, 2020 at 2:48 PM Martin Grigorov <mgrigo...@apache.org> > wrote: > > > Hi, > > > > Shall we backport these commits to 9.x and 8.5? > > It will make it easier to backport future changes in these classes. > > > > +1 > > No need to diverge the branches unnecessarily. >
+1 to backport to 9.0, but not to Tomcat 8.5 since it would need to be Java 7 compatible [some of the changes might be fine, but for others it's not possible]. Rémy > > Igal > > > > > > > Martin > > > > On Fri, Dec 4, 2020, 00:06 Emmanuel Bourg <ebo...@apache.org> wrote: > > > > > Hi Christopher, > > > > > > Le 03/12/2020 à 21:49, Christopher Schultz a écrit : > > > > > > > I'm curious as to why this change is warranted. I'm not suggesting > it's > > > > not... just wondering what the benefit is? Avoiding a pass-through > > > > method call? > > > > > > It's the shorter idiom to sort lists with Java 8+, it just improves the > > > readability. I don't think the method call avoided has any impact, the > > > actual sorting dominates the time spent anyway. > > > > > > Emmanuel Bourg > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > >
