Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-21 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2898611254 > > Fixed for 11.0.8 onwards. > > Saw the commit. Many thanks. Thus now applications can work as before. I will test our application + Latest wicket 10.x against unreleased tomcat and

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-21 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2898290558 > Fixed for 11.0.8 onwards. Saw the commit. Many thanks. Thus now applications can work as before. I will test our application + Latest wicket 10.x against unreleased tomcat and conf

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-21 Thread via GitHub
markt-asf commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2898190448 Fixed for 11.0.8 onwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-21 Thread via GitHub
markt-asf closed pull request #856: allow users to plug in a ProgressListener via some factory. URL: https://github.com/apache/tomcat/pull/856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891431758 > > * If you do not set the casualMultipartConfig or the @MultipartConfig tomcat will complain when getParameters is called > > That looks like a Tomcat bug but I need to confirm that

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
markt-asf commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891416271 > * If you do not set the casualMultipartConfig or the @MultipartConfig tomcat will complain when getParameters is called That looks like a Tomcat bug but I need to confirm that. Ass

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891405212 > > This is how all started ... > > Not quite. The provided reproducer uses the `@MultipartConfig` annotation. Therefore, for that configuration, it is working as designed. Not

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
markt-asf commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891358727 > This is how all started ... Not quite. The provided reproducer uses the `@MultipartConfig` annotation. Therefore, for that configuration, it is working as designed. -- This is a

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891175364 > It looks like Tomcat parsing parts for `multipart/form-data` with no `` as a result of calling `getParameter()` and friends is a bug although I need to check the TCK. Fix that and the Wic

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
markt-asf commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891145754 It looks like Tomcat parsing parts for `multipart/form-data' with no `` as a result of calling getParemeter() and friends is a bug although I need to check the TCK. Fix that and the Wicket

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890957828 > > IMHO what is described there is not what we need... because it has the same problem we have now. > > Which is what, exactly? You suggested to avoid using multipart... but a

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890882787 > > IMHO what is described there is not what we need... because it has the same problem we have now. > > Which is what, exactly? The problem now is: 1) "someone" calls getParam

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
markt-asf commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890457132 > IMHO what is described there is not what we need... because it has the same problem we have now. Which is what, exactly? -- This is an automated message from the Apache Git Serv

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890416198 > See [jakartaee/servlet#66](https://github.com/jakartaee/servlet/issues/66) Thanks for the link. See https://github.com/jakartaee/servlet/issues/66#issuecomment-2890413278

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890315507 > Personally I am not a fan at all right now: > Ok. > * About the way it is hooked in Request and esp ApplicationContext. I'm totally new to Tomcat code-base. I tried to

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
rmaucher commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890282071 Let's see how the feature proposal progresses first then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
markt-asf commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890250497 See https://github.com/jakartaee/servlet/issues/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
rmaucher commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890245052 Personally I am not a fan at all right now: - About the way it is hooked in Request and esp ApplicationContext. - It changes fileupload, which is a separate component (fileupload would

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-19 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890201043 @ChristopherSchultz any chances to get this PR merged into Tomcat 11? - Any other work to be done from my side? - Add tests? - Back-port this to previous tomcat versions?

Re: [PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-18 Thread via GitHub
reiern70 commented on PR #856: URL: https://github.com/apache/tomcat/pull/856#issuecomment-2889048692 @ChristopherSchultz I have implemented https://github.com/apache/wicket/pull/1167 A way to get Wicket's support for upload with progress using work in this PR. -- This is an

[PR] allow users to plug in a ProgressListener via some factory. [tomcat]

2025-05-13 Thread via GitHub
reiern70 opened a new pull request, #856: URL: https://github.com/apache/tomcat/pull/856 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail