Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-18 Thread via GitHub
michael-o closed pull request #21: Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows URL: https://github.com/apache/tomcat-native/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-18 Thread via GitHub
michael-o commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1770165905 Closing this and will leave the branch for some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-17 Thread via GitHub
michael-o commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766350741 > No, that is not my position. I've updated my comment to clarify my position. Users that want to build for Windows from source can do so. They need to use a currently supported versi

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-17 Thread via GitHub
markt-asf commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766273379 No, that is not my position. I've updated my comment to clarify my position. Users that want to build for Windows from source can do so. They need to use a currently supported version

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-17 Thread via GitHub
michael-o commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766232407 > I disagree. OpenSSL 1.1.1 is no longer supported on Windows. There is no need to support building Tomcat Native with OpenSSL on Windows. OpenSSL 1.1.1 is supported on some Linux dis

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-17 Thread via GitHub
markt-asf commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766227205 I disagree. OpenSSL 1.1.1 is no longer supported on Windows. There is no need to support building Tomcat Native with OpenSSL on Windows. OpenSSL 1.1.1 is supported on some Linux dis

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-17 Thread via GitHub
michael-o commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766217900 > I don't think this PR should be applied. 1.1.1 is no longer supported on Windows. The problem *I* have is that we still allow 1.x to build and link against 1.1.1, thus any ch

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-17 Thread via GitHub
markt-asf commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766206442 I don't think this PR should be applied. 1.1.1 is no longer supported on Windows. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-17 Thread via GitHub
michael-o commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1766102093 If I don't have any objections I will merge this in the next couple of days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-13 Thread via GitHub
michael-o opened a new pull request, #21: URL: https://github.com/apache/tomcat-native/pull/21 This patch has been recently removed because it does not apply to the latest version. Bring back an updated patch because Tomcat Native 1.2.x still supports 1.1.1 for those who need it on Windows,