Re: [PR] Fix null stream issue for resource loading based on relative paths [tomcat]

2025-02-05 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2636628313 Adding to my comment above, when the `name` variable passed is a name without the leading slash and the external repository lookup succeeds using this value, should we be failing the attemp

Re: [PR] Fix null stream issue for resource loading based on relative paths [tomcat]

2025-02-05 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2636564607 > These are names not paths. > > I'm not convinced that 'relative' and 'absolute' are concepts that apply here. As per the [Java documentation for resource names](https://docs.

Re: [PR] Fix null stream issue for resource loading based on relative paths [tomcat]

2025-02-04 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2633689545 These are names not paths. I'm not convinced that 'relative' and 'absolute' are concepts that apply here. Putting that to one side, where is the target resource located so tha

Re: [PR] Fix null stream issue for resource loading based on relative paths [tomcat]

2025-02-04 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2633658818 Sorry, I meant absolute and relative paths, not URLs. I have updated the description body to reflect this. An example case would be the calling the [`getResourceAsStream` method in A

Re: [PR] Fix null stream issue for resource loading based on relative paths [tomcat]

2025-02-03 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2630705976 `getResourceAsStream()` is documented to accept a name, not a URL. I'd like to understand the use case better before making any changes. Can you provide some sample code or a test case or

[PR] Fix null stream issue for resource loading based on relative paths [tomcat]

2025-01-30 Thread via GitHub
AmshikaH opened a new pull request, #816: URL: https://github.com/apache/tomcat/pull/816 In the getResourceAsStream [1] method, Tomcat checks the recently introduced `notFoundClassResources` based on the "path" variable alone, which is always the absolute url. However, there are case