AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2636628313
Adding to my comment above, when the `name` variable passed is a name without the leading slash and the external repository lookup succeeds using this value, should we be failing the attempt based on a previous call where the name was a different value, i.e., with the slash, and preventing the non-slash lookup from executing? This PR proposes updating the flow from checking only the `path` variable commonly prior to both lookups based on the `path` (line 1102) and `name` (line 1109) to checking for the `path` variable prior to the `path` based lookup, and checking for the `name` prior to the `name` based lookup for backward compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
