Re: [PATCH] - Remove redundant code in Mapper.java

Remy Maucherat wrote: > I am not certain they're that redundant. I would leave them in just to I'm not quite sure I understand why, so please could you elaborate. * Since setString() is invoked after setChars(), a toString() on (which is pretty much the only method invoked on mappingData.reques

Re: [PATCH] - Remove redundant code in Mapper.java

>> Attached is a simple patch (for TC 6.0's trunk) that removes a couple >> of lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper > > I am not certain they're that redundant. I would leave them in just to > be safe given that the cost of these calls is very low. They are not red

Re: [PATCH] - Remove redundant code in Mapper.java

Arvind Srinivasan wrote: Attached is a simple patch (for TC 6.0's trunk) that removes a couple of lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper I am not certain they're that redundant. I would leave them in just to be safe given that the cost of these calls is very low.

[PATCH] - Remove redundant code in Mapper.java

Attached is a simple patch (for TC 6.0's trunk) that removes a couple of lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper Arvind Index: java/org/apache/tomcat/util/http/mapper/Mapper.java === --- java/org/apache/