[GitHub] [tomcat] oopexpert edited a comment on issue #242: get a hands on ...

2020-02-15 Thread GitBox
oopexpert edited a comment on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586642730 > Refactorings are nice, but you start to have to argue about them, then it's not the best thing. Serious? > As a general rule of thumb ... Ideall

[GitHub] [tomcat] oopexpert edited a comment on issue #242: get a hands on ...

2020-02-15 Thread GitBox
oopexpert edited a comment on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586642121 > If Im not mistaken and if it helps, you can cache the method after the first call then cost will be negligible. I could but it would change the asserti

[GitHub] [tomcat] oopexpert edited a comment on issue #242: get a hands on ...

2020-02-15 Thread GitBox
oopexpert edited a comment on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586642121 > If Im not mistaken and if it helps, you can cache the method after the first call then cost will be negligible. I could but it would change the asserti

[GitHub] [tomcat] oopexpert edited a comment on issue #242: get a hands on ...

2020-02-14 Thread GitBox
oopexpert edited a comment on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586561346 I do understand that there are some prequistes that I did not consider according to the Java 8 deps. It would be helpful to get a hint what kind of line of cod

[GitHub] [tomcat] oopexpert edited a comment on issue #242: get a hands on ...

2020-02-14 Thread GitBox
oopexpert edited a comment on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586561346 I do understand that there are some prequistes that I did not consider according to the Java 8 deps. It would be helpful to get a hint what kind of line of cod