oopexpert edited a comment on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586642121 > If Im not mistaken and if it helps, you can cache the method after the first call then cost will be negligible. I could but it would change the assertion of the "allow trace" evaluation. I tried to keep the assertions as they were during my refactoring. Who knows which methods rely on a non-cached "allow trace evaluation"? > Very worse case you make a catalina class implementing Function<HttpServletRequest, xxx> or equivalent in catalina and instantiate it at first call in the servlet (these classes are available) by reflection then it is native code. Please rephrase it. I do not understand what you mean. > So we are not yet at java limitations IMHO. I never said that. I only see no problem with the 18% performance decrease. This is because... ... reflection calls are the crucial parts which were already part of the previous implementations ... the doOption() method will surely never be called 10 million times in 4 seconds
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
