[GitHub] [tomcat] oopexpert commented on issue #242: get a hands on ...

2020-02-16 Thread GitBox
oopexpert commented on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586698111 > Performance numbers are objective and while a refactoring that makes a small piece of code ~3x slower is going to have a negligible impact on performance, the idea

[GitHub] [tomcat] oopexpert commented on issue #242: get a hands on ...

2020-02-15 Thread GitBox
oopexpert commented on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586642730 > Refactorings are nice, but you start to have to argue about them, then it's not the best thing. Serious? > As a general rule of thumb ... Ideally for a fir

[GitHub] [tomcat] oopexpert commented on issue #242: get a hands on ...

2020-02-15 Thread GitBox
oopexpert commented on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586642121 > If Im not mistaken and if it helps, you can cache the method after the first call then cost will be negligible. I could but it would change the assertion of the "

[GitHub] [tomcat] oopexpert commented on issue #242: get a hands on ...

2020-02-15 Thread GitBox
oopexpert commented on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586633902 I did the performance measurement. My setup: i5 4440 CPU 3,1 GHz 10.000.000 calls on doOptions Current implementation: 1,381 seconds My implementation: 3,85

[GitHub] [tomcat] oopexpert commented on issue #242: get a hands on ...

2020-02-14 Thread GitBox
oopexpert commented on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586561346 I do understand that there are some prequistes that I did not consider according to the Java 8 deps. It would be helpful to get a hint what kind of line of code does