https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
Matafagafo changed:
What|Removed |Added
CC||matafag...@gmail.com
--
You are receivin
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
--- Comment #8 from John Engebretson ---
Created attachment 39986
--> https://bz.apache.org/bugzilla/attachment.cgi?id=39986&action=edit
Proposed patch v2
Updated patch attached - added AL text, reduced class visibility, cleaned up a
workspa
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
--- Comment #7 from Mark Thomas ---
I like it. I do have a couple of minor comments:
- ExpressionFactoryCache needs to be package private. It can't be public as we
aren't allowed to add classes to the public API of a specification package.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
--- Comment #6 from John Engebretson ---
This patch also reduces the runtime of the existing perf test
TestELParserPerformance.testExpressions() by about 15-20%, and heap usage by
25%. Hopefully it is indeed thread safe?
--
You are receiving
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
--- Comment #5 from John Engebretson ---
Created attachment 39979
--> https://bz.apache.org/bugzilla/attachment.cgi?id=39979&action=edit
Tomcat 9 proposed patch
I've attached a patch that improves on the current state in lots of ways:
1. No
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
--- Comment #4 from John Engebretson ---
Interestingly, ExpressionFactory.newInstance() uses the same locking logic as
Util.getExpressionFactory(). Looks like a copy-and-modify from one to the
other.
--
You are receiving this mail because:
Y
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
--- Comment #3 from Mark Thomas ---
Looking at the history, I think Konstantin deserves the credit for the original
design rather than me.
Given the current implementation maintains a TCCL->class name Map and a
TTCL->ExpressionFactory Map, I d
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
--- Comment #2 from John Engebretson ---
You're probably right about the history. An AtomicReference might help here.
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=69532
Remy Maucherat changed:
What|Removed |Added
OS||All
--- Comment #1 from Remy Mauchera
10 matches
Mail list logo
