[Bug 69377] JSP optimization via custom code generation

2025-04-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #15 from John Engebretson --- Merged to 9.0.x, would appreciate verification before I repeat for 10 and 11. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Bug 69377] JSP optimization via custom code generation

2025-04-17 Thread Niranjan Pai
Ok On Thu, 17 Apr, 2025, 9:03 pm , wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 > > --- Comment #14 from John Engebretson --- > Will do, thank you! Appreciate the cleanup. > > -- > You are receiving this mail because: > You are the assignee for the bug. > -

[Bug 69377] JSP optimization via custom code generation

2025-04-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #14 from John Engebretson --- Will do, thank you! Appreciate the cleanup. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscr

[Bug 69377] JSP optimization via custom code generation

2025-04-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #13 from Mark Thomas --- Don't forget the additional fixes I applied this morning. You can merge them all into a single commit in your name. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69377] JSP optimization via custom code generation

2025-04-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #12 from John Engebretson --- Merged to 12, backports in progress. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-m

[Bug 69377] JSP optimization via custom code generation

2025-04-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #11 from John Engebretson --- PR published, ready for review. Performance data looks good. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 69377] JSP optimization via custom code generation

2025-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #9 from John Engebretson --- Thank you! I'll target the PR for 12 and we can go from there. Init param on the servlet makes sense, thanks! -- You are receiving this mail because: You are the assignee for the bug.

[Bug 69377] JSP optimization via custom code generation

2025-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #8 from Mark Thomas --- Small scope is fine. Generally, I'd prefer to review a series of smaller changes than one big one. Generally, we add features in 12 and back-port. As long as backwards compatibility is not impacted, new feat

[Bug 69377] JSP optimization via custom code generation

2025-03-31 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #7 from John Engebretson --- I'm getting ready to work on this, would appreciate a mini-review of my plan: 1. Initial scope is to remove simple cases of : values and vars are single EL expression, scope is one of the built-in value

[Bug 69377] JSP optimization via custom code generation

2024-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #6 from Mark Tho

[Bug 69377] JSP optimization via custom code generation

2024-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #5 from John Engebretson --- I'm going to proceed with the tag plugin mechanism, configured for strictly c:set and c:if. This captures at least half the opportunity, with no code changes required and with little risk of hitting the

[Bug 69377] JSP optimization via custom code generation

2024-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #4 from John Engebretson --- The biggest error comes when a JSP uses the following structure: I didn't know this was a supported behavior, but it shows up throughout our application. The code generation for delegates the

[Bug 69377] JSP optimization via custom code generation

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #3 from John Engebretson --- Thank you! I've enabled it locally and immediately ran into some edge case bugs causing a few JSPs to fail compilation. I'll work through those and contribute fixes on this ticket. -- You are receivi

[Bug 69377] JSP optimization via custom code generation

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #2 from Remy Maucherat --- This is certainly a feature from a long time ago (Tomcat 5). At the time Kin-man did it because JSTL was very very slow. Obviously tags remain an order of magnitude slower than hand crafted code. Anyway,

[Bug 69377] JSP optimization via custom code generation

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #1 from John Engebretson --- So, I found my way to TagPluginManager, and the existing code in org.apache.jasper.tagplugins.jstl.core that does exactly what I asked for. Sorry. :) Do I correctly grasp that I need a dedicated XML f