[Bug 60488] NPE in Request.parseCookies()

2017-01-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60488 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 60488] NPE in Request.parseCookies()

2016-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60488 --- Comment #5 from Ben Wolfe --- Yes, we do set that too, I just neglected to copy it in: _request.setCoyoteRequest( new org.apache.coyote.Request() ); I did make a mistake, seems its the connector that is null on that line, not the serverCoo

[Bug 60488] NPE in Request.parseCookies()

2016-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60488 --- Comment #4 from Remy Maucherat --- Well, if you're using the real org.apache.catalina.connector.Request object, it needs a non null org.apache.coyote.Request coyoteRequest field to work properly (which then takes care of the serverCookies i

[Bug 60488] NPE in Request.parseCookies()

2016-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60488 --- Comment #3 from Ben Wolfe --- The test in my code does this, why should I need to generate mock objects? _request = new Request(); Context context = new StandardContext(); context.setCookieProcessor( new LegacyCookieProcessor() ); _request

[Bug 60488] NPE in Request.parseCookies()

2016-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60488 --- Comment #2 from Remy Maucherat --- In that kind of situation, we usually fix the mock object (TesterRequest here) to make it more complete. But it's not failing any Tomcat test, so there's nothing to fix here. You should probably add your o

[Bug 60488] NPE in Request.parseCookies()

2016-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60488 --- Comment #1 from Ben Wolfe --- Created attachment 34529 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34529&action=edit Patch to fix NPE See attached patch to fix this. -- You are receiving this mail because: You are the assignee