[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-11-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 Mark Thomas changed: What|Removed |Added CC||bill.tom...@beanfactory.co.

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 Rainer Jung changed: What|Removed |Added CC||j...@guno.nl --- Comment #11 from Ra

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #10 from Konstantin Kolinko --- (In reply to comment #9) > (In reply to comment #8) > > The JspReader.skipUntil(..) method is invoked with the following arguments: > > skipUntil(" > skipUntil("--%>"); > > skipUntil("%>"); > > sk

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #9 from Christopher Schultz --- (In reply to comment #8) > The JspReader.skipUntil(..) method is invoked with the following arguments: > skipUntil(" skipUntil("--%>"); > skipUntil("%>"); > skipUntil("<"); > skipUntil(">"); > ski

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #8 from Konstantin Kolinko --- (In reply to comment #6) > Found the problem. It is line 429 of JspReader: > > setCurrent(restart); > > This makes the current Mark and the reset Mark the same object and they need > to be kept s

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #6 from Mark Thomas --- Found the problem. It is line 429 of JspReader: setCurrent(restart); This makes the current Mark and the reset Mark the same object and they need to be kept separate. Looking at a fix now. It is possibl

Re: [Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-10 Thread Mark Thomas
Christopher Schultz wrote: >All, > >On 10/9/12 6:07 PM, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 >> >> --- Comment #4 from Christopher Schultz > --- >> (In reply to comment #3) >>> Possible cause: r1381417 >> >> Reverting that patch resolves the iss

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #5 from Steve Ratay --- (In reply to comment #4) Thanks Chris. I actually only had a single JSP with this problem, so I already fixed the JSP and am up and running on 7.0.32. However, since it appeared to be a regression from

Re: [Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread Christopher Schultz
All, On 10/9/12 6:07 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 > > --- Comment #4 from Christopher Schultz --- > (In reply to comment #3) >> Possible cause: r1381417 > > Reverting that patch resolves the issue in 7.0.x/trunk, so the regression > a

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #4 from Christopher Schultz --- (In reply to comment #3) > Possible cause: r1381417 Reverting that patch resolves the issue in 7.0.x/trunk, so the regression appears to be in there. I'm not sure where, though. Steve, a workaro

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #3 from Mark Thomas --- Possible cause: r1381417 I haven't looked into this yet but that is where I'd start. -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #2 from Christopher Schultz --- I thought there might be language in the spec to say that (like XML) the string "--" cannot appear in the comment itself but that's not the case. >From the 2.2 spec: " JSP.1.5.1.2 JSP Comments A

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 Christopher Schultz changed: What|Removed |Added OS||All --- Comment #1 from Chri

[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 Christopher Schultz changed: What|Removed |Added Attachment #29466|application/octet-stream|text/plain mime typ