Re: (tomcat) branch main updated: Allow different implementations for RateLimitFilter

2024-10-06 Thread Igal Sapir
Mark, > >> On Sun, Oct 6, 2024 at 8:48 AM Mark Thomas wrote: >> >>> On 06/10/2024 16:09, Igal Sapir wrote: >>> > On Sun, Oct 6, 2024, 06:43 Mark Thomas wrote: >>> >>> >>> >>> >> I think this needs to be renamed for consistency. Generally, we use >>> >> className to define the implementing clas

Re: (tomcat) branch main updated: Allow different implementations for RateLimitFilter

2024-10-06 Thread Mark Thomas
On 06/10/2024 16:09, Igal Sapir wrote: On Sun, Oct 6, 2024, 06:43 Mark Thomas wrote: I think this needs to be renamed for consistency. Generally, we use className to define the implementing class of the component being defined. For sub-components, we use something like rateLimiterClassName.

Re: (tomcat) branch main updated: Allow different implementations for RateLimitFilter

2024-10-06 Thread Igal Sapir
Mark, On Sun, Oct 6, 2024, 06:43 Mark Thomas wrote: > On 06/10/2024 06:54, isa...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > isapir pushed a commit to branch main > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > T

Re: (tomcat) branch main updated: Allow different implementations for RateLimitFilter

2024-10-06 Thread Mark Thomas
On 06/10/2024 06:54, isa...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 9cc

(tomcat) branch main updated: Allow different implementations for RateLimitFilter

2024-10-05 Thread isapir
This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 9cc44dcca2 Allow different implementations for RateL