On 06/10/2024 16:09, Igal Sapir wrote:
On Sun, Oct 6, 2024, 06:43 Mark Thomas <ma...@apache.org> wrote:
<snip/>
I think this needs to be renamed for consistency. Generally, we use
className to define the implementing class of the component being
defined. For sub-components, we use something like rateLimiterClassName.
For an example, have a look at the Manager class where we have className
and secureRandomClass.
Sounds good. I was looking for example in the Connector configuration in
server.xml and was unaware of the distinction between a component and a
subcomponent.
Are these rules/conventions documented anywhere? I'd be happy to start it
if not but I'm not sure where would be a good place.
I don't think they are documented. The wiki is probably the place for that.
<snip/>
Thank you. I will apply the changes above ASAP.
Tx.
FYI, I am currently looking at all of the Filters to see if any
can/should take advantage of the init-param setting provided by the base
class. This looks like a candidate for that but I should be able to take
care of it (just as soon as I figure out what I have done wrong that has
broken the test).
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
