[GitHub] tomcat pull request: Add JASPIC API (JSR 196) to build process

2015-06-10 Thread fjodorver
Github user fjodorver commented on the pull request: https://github.com/apache/tomcat/pull/21#issuecomment-110630412 2,4,5) I use ant validate for checkstyle validation. Is it enough? 3) It looks like we need to rewrite AuthConfigFactory anyway (for example, possible memory leaks

[GitHub] tomcat pull request: Add JASPIC API (JSR 196) to build process

2015-06-08 Thread fjodorver
Github user fjodorver commented on the pull request: https://github.com/apache/tomcat/pull/21#issuecomment-110251900 It's updated pull request. 1) Build.xml configuration in separate commit now 2) Fixed imports and formatting 3) Method refactoring has been made separ

[GitHub] tomcat pull request: Add JASPIC API (JSR 196) to build process

2015-06-07 Thread fjodorver
GitHub user fjodorver opened a pull request: https://github.com/apache/tomcat/pull/21 Add JASPIC API (JSR 196) to build process I'd added jaspic api support in this commit. You can merge this pull request into a Git repository by running: $ git pull https://githu