Re: AccessLogValve enhancement

2012-02-17 Thread Francis Galiegue
t patterns... -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least some 'business intelligence' tools invest so much intelligence on the business side that they have nothing left for generating SQL queries" (Stéphane Faroult, in "

Re: Tomcat 7.0.23 startup freezes at "INFO: Deploying web application directory ..."

2011-11-29 Thread Francis Galiegue
ll previous build, including 7.0.22 > - when lib/*.jar files of tomcat-7.0.23 are replaced with lib/*.jar files of > tomcat-7.0.23 - everything works just fine > Try and add this option to the JVM: -Djava.security.egd=file:/dev/./urandom (note: the extra dot is NECESSARY). -- Francis Ga

Re: svn commit: r1198376 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread Francis Galiegue
On Sun, Nov 6, 2011 at 19:31, Olivier Lamy wrote: > 2011/11/6 Francis Galiegue : >> On Sun, Nov 6, 2011 at 15:13,   wrote: >> [...] >>> >>> +                    tmpDir.mkdirs(); >> >> Why isn't the return code checked? Are you sure at this poi

Re: svn commit: r1198376 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread Francis Galiegue
On Sun, Nov 6, 2011 at 15:13, wrote: [...] > > +                    tmpDir.mkdirs(); Why isn't the return code checked? Are you sure at this point that you can actually create the directories? What about ENOSPC? -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [..

Re: IDEA settings for Tomcat development?

2011-10-28 Thread Francis Galiegue
On Fri, Oct 28, 2011 at 19:25, Konstantin Kolinko wrote: > 2011/10/28 Francis Galiegue : >> Hello list, >> >> I understand some of you use IDEA for developing Tomcat. So do I. Can >> you share your project settings (I am thinking in particular about >> in

IDEA settings for Tomcat development?

2011-10-28 Thread Francis Galiegue
se any concerns? Have fun, -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least some 'business intelligence' tools invest so much intelligence on the business side that they have nothing left for generating SQL queries" (Stéphane Faroult, in &

Re: svn commit: r1189436 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-10-26 Thread Francis Galiegue
On Wed, Oct 26, 2011 at 22:40, wrote: > Author: kkolinko > Date: Wed Oct 26 20:40:20 2011 > New Revision: 1189436 > [...] Ouch. My proposal has just become a lot more complicated :p -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least some '

Re: Enhancement review process?

2011-10-26 Thread Francis Galiegue
On Wed, Oct 26, 2011 at 21:40, Mark Thomas wrote: >> >> +     * @return true if a problem should trigger the >> failure of this > > So? > true. -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least some 'business intelligence'

Re: Enhancement review process?

2011-10-26 Thread Francis Galiegue
On Wed, Oct 26, 2011 at 21:17, Mark Thomas wrote: > On 26/10/2011 20:07, Francis Galiegue wrote: >> Hello, >> >> It has been now three weeks since I opened this enhancement request: >> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=51953 >> >>

Enhancement review process?

2011-10-26 Thread Francis Galiegue
st to cite an example), but it has now been ten days and I haven't had a single comment on things to improve etc. How are enhancement requests reviewed? How long does it normally take for such a request to be considered for inclusion? -- Francis Galiegue, fgalie...@gmail.com "It seems obv

Re: Question regarding of an implementation of a custom Valve

2011-10-21 Thread Francis Galiegue
he above definition? > > I looked up the source of AccesslogValve, but I didn't see any > browsing of the > > Is it that I just have to specify a getter / setter inside my > Valve-source for the corresponding attribute inside the > Valve-specification, and it will be picke

Re: [RFC] Netmask-based filter and valve

2011-10-14 Thread Francis Galiegue
On Tue, Oct 11, 2011 at 14:09, Francis Galiegue wrote: [...] > > Yes, I was kind of wondering whether the .get*() methods required > symmetry with .put*(). So, this is one of my questions answered. > > Along with the question of why Remote{Host,Addr}Filter cleared allow &g

Re: Git and tomcat 7.x

2011-10-14 Thread Francis Galiegue
On Fri, Oct 14, 2011 at 20:08, Mark Thomas wrote: > On 14/10/2011 19:00, Francis Galiegue wrote: >> [...] The trouble is >> that I don't feel like git svn cloning directly given that my >> bandwidth is very poor and the Apache SVN repo has a number of commits >> i

Git and tomcat 7.x

2011-10-14 Thread Francis Galiegue
o and base my netmask filtering patches over the new repo? The trouble is that I don't feel like git svn cloning directly given that my bandwidth is very poor and the Apache SVN repo has a number of commits in the 7 digit range (even if the first of these 7 is "just" a 1)... -- Fran

Re: [RFC] Netmask-based filter and valve

2011-10-11 Thread Francis Galiegue
ng them... I'll rework this part, along with exception handling. Thanks for the comments, -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least some 'business intelligence' tools invest so much intelligence on the business side that

Re: [RFC] Netmask-based filter and valve

2011-10-11 Thread Francis Galiegue
On Tue, Oct 11, 2011 at 11:41, Konstantin Kolinko wrote: > 2011/10/10 Francis Galiegue : >> error handling (what >> should be done when an illegal netmask is supplied, etc). > > I think the called method should fail with some RuntimeException. > > That is wha

[RFC] Netmask-based filter and valve

2011-10-10 Thread Francis Galiegue
ut it: I want to get the code "in shape" first] Comments appreciated, -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least some 'business intelligence' tools invest so much intelligence on the business side that they have nothing left for generatin

Make the InetAddress object available via ServletRequest?

2011-10-09 Thread Francis Galiegue
t you get hold of the InetAddress object directly? It would be much faster to do so... In my valve and filter, I have to .getRemoteAddr() and create an InetAddress object out of the string... -- Francis Galiegue, fgalie...@gmail.com "It seems obvious [...] that at least some 'busine

[PATCH] Fix suspicious logic operator usage

2011-10-05 Thread Francis Galiegue
Found by FindBugs. startService() and stopService() both return boolean, so it is likely that the '&' is a typo and '&&' was meant. --- .../tribes/membership/McastServiceImpl.java|2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/java/org/apache/catalina/tribes/membe