On Tue, Oct 11, 2011 at 11:41, Konstantin Kolinko <[email protected]> wrote: > 2011/10/10 Francis Galiegue <[email protected]>: >> error handling (what >> should be done when an illegal netmask is supplied, etc). > > I think the called method should fail with some RuntimeException. > > That is what will happen with existing RemoteAddrValve if you pass a > value that Pattern.compile() cannot handle. (See > RequestFilterValve#setAllow(String)). > > It would not be safe to operate a Valve that is misconfigured. >
OK, I will update the code, post an updated version in the Bugzilla entry and add more questions over there (#51953). -- Francis Galiegue, [email protected] "It seems obvious [...] that at least some 'business intelligence' tools invest so much intelligence on the business side that they have nothing left for generating SQL queries" (Stéphane Faroult, in "The Art of SQL", ISBN 0-596-00894-5) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
