Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Filip Hanik
On Mon, Aug 8, 2022 at 3:15 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > The proposed Apache Tomcat 8.5.82 release is now available for voting. > > The notable changes compared to 8.5.81 are: > > - Update the packaged version of the Tomcat Native Library to 1.2.35 to > pic

Re: Plans for Tomcat Native

2022-05-23 Thread Filip Hanik
Sounds like a healthy plan. +1 On Mon, May 23, 2022 at 03:52 Mark Thomas wrote: > Hi all, > > A question on the users list about Tomcat Native, OpenSSL 3.0 FIPs > caused me to take a look at the current state of supported versions. > > The detail is here: > https://github.com/apache/tomcat-nativ

Re: [VOTE] Release Apache Tomcat 8.5.79

2022-05-16 Thread Filip Hanik
On Mon, May 16, 2022 at 9:14 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > The proposed Apache Tomcat 8.5.79 release is now available for voting. > > The notable changes compared to 8.5.78 are: > > - Provide a property source that sources values from Kubernetes service > bind

Re: [VOTE] Release Apache Tomcat 10.0.21

2022-05-10 Thread Filip Hanik
On Tue, May 10, 2022 at 3:39 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.21 release is now available for > voting. > > Apache Tomcat 10.0.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > > Applicatio

Re: [VOTE] Release Apache Tomcat 10.1.0-M15

2022-05-10 Thread Filip Hanik
On Tue, May 10, 2022 at 1:24 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.1.0-M15 release is now available for > voting. > > Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 > without changes. Java EE applications designed for Tomcat 9 and earlier > may be placed i

Re: Native Compilation, Continuation 2022

2022-04-13 Thread Filip Hanik
On Wed, Apr 13, 2022 at 9:45 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > Filip, > > On 4/11/22 18:32, Filip Hanik wrote: > > Hi folks, > > > > I'm jumping in on the bandwagon again. Specifically to talk some more > about > > n

Native Compilation, Continuation 2022

2022-04-11 Thread Filip Hanik
Hi folks, I'm jumping in on the bandwagon again. Specifically to talk some more about native compilation. The graal compiler is making headway, and it's becoming better and better at native compilation [1]. I'll put some historical context at the bottom of this post for clarity. I have a few sugg

Re: [VOTE] Release Apache Tomcat 8.5.78

2022-03-31 Thread Filip Hanik
On Thu, Mar 31, 2022 at 9:55 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.78 release is now available for voting. > > The notable changes compared to 8.5.77 are: > > - Update the packaged version of the Tomcat Native Library to 1.2.32 to > pick up Windows binaries built with OpenSSL

Re: [VOTE] Release Apache Tomcat 9.0.62

2022-03-31 Thread Filip Hanik
On Thu, Mar 31, 2022 at 7:56 AM Rémy Maucherat wrote: > The proposed Apache Tomcat 9.0.62 release is now available for voting. > > The notable changes compared to 9.0.60 are: > > - Update the packaged version of the Tomcat Native Library to 1.2.32 to >pick up Windows binaries built with OpenS

Re: [tomcat] branch 10.0.x updated: Add compilation support for Graal 21.3

2022-01-10 Thread Filip Hanik
From: Mark Thomas Sent: Monday, January 10, 2022 9:49 AM To: dev@tomcat.apache.org Subject: Re: [tomcat] branch 10.0.x updated: Add compilation support for Graal 21.3 On 10/01/2022 17:45, fha...@apache.org wrote: > This is an automated email from the ASF dua

Re: [VOTE] Release Apache Tomcat 9.0.54

2021-09-29 Thread Filip Hanik
[X] Stable - go ahead and release as 9.0.54 (stable) On Tue, Sep 28, 2021 at 7:25 AM Rémy Maucherat wrote: > The proposed Apache Tomcat 9.0.54 release is now available for voting. > > The notable changes compared to 9.0.54 are: > > - Further robustness improvements to HTTP/2 flow control window

Re: [VOTE] Release Apache Tomcat 10.0.12

2021-09-29 Thread Filip Hanik
[X] Stable - go ahead and release as 10.0.12 (stable) On Tue, Sep 28, 2021 at 6:59 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.12 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs h

Re: [VOTE] Release Apache Tomcat 10.1.0-M6

2021-09-29 Thread Filip Hanik
[X] Alpha - go ahead and release as 10.1.0-M6 (alpha) On Tue, Sep 28, 2021 at 5:31 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.1.0-M6 release is now available for > voting. > > Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 > without changes. Java EE applicatio

Re: [PROPOSAL] Deprecate JAAS Realm in 10.0.x and remove in 10.1.x

2021-04-26 Thread Filip Hanik
On Mon, Apr 26, 2021 at 09:17 Mark Thomas wrote: > In reviewing references to Java EE (and J2EE) remaining in the Tomcat 10 > repo I found the following: > > > JAASRealm is prototype for Tomcat of the JAAS-based J2EE authentication > framework for J2EE v1.4, based on the href="https://www.jcp.o

Re: Integrating migration tool into Tomcat 10

2021-02-09 Thread Filip Hanik
On Tue, Feb 9, 2021 at 14:34 Rémy Maucherat wrote: > On Tue, Feb 9, 2021 at 10:12 PM Mark Thomas wrote: > > > Hi all, > > > > I've been looking at the options to integrate the Java EE to Jakarta EE > > migration functionality into Tomcat 10. > > > > There are essentially two ways to do this: dep

Re: [VOTE] Release Apache Tomcat 8.5.63

2021-01-30 Thread Filip Hanik
[X] Stable - go ahead and release as 8.5.63 On Fri, Jan 29, 2021 at 03:43 Mark Thomas wrote: > The proposed Apache Tomcat 8.5.63 release is now available for voting. > > The notable changes compared to the 8.5.61 release are: > > - Add a new StringInterpreter interface that allows applications

Re: [VOTE] Release Apache Tomcat 9.0.42

2021-01-27 Thread Filip Hanik
[X] Stable - go ahead and release as 9.0.42 On Wed, Jan 27, 2021 at 9:40 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.42 release is now available for voting. > > The notable changes compared to the 9.0.41 release are: > > - Add support for using Unix domain sockets for NIO when running

Re: [VOTE] Release Apache Tomcat 10.0.1

2021-01-27 Thread Filip Hanik
[X] Stable - go ahead and release as 10.0.1 (stable) On Wed, Jan 27, 2021 at 8:29 AM Mark Thomas wrote: > On 27/01/2021 15:08, Mark Thomas wrote: > > > The proposed 10.0.1 release is: > > [ ] Broken - do not release > > [ ] Beta - go ahead and release as 10.0.1 (beta) > > [X] Stable - go ahead

Re: Tomcat 10.0.x and Jakarta 9 TCK status

2020-11-23 Thread Filip Hanik
Thanks for the update. Good work! On Mon, Nov 23, 2020 at 07:07 Mark Thomas wrote: > Hi all, > > Now that the final versions of the TCKs for Jakarta 9 are available I've > been running them against the current 10.0.x (effectively 10.0.0-M10). > > The results can be summarised as: > > Expression

Re: Removing JDBC mode from JDBCStore

2020-11-09 Thread Filip Hanik
+1 On Mon, Nov 9, 2020 at 05:45 Rémy Maucherat wrote: > Hi, > > As part of https://github.com/apache/tomcat/pull/376 and along with the > similar removal of JDBCRealm, I would like to propose: > - Remove JDBC code from JDBCStore in Tomcat 10, in favor of DataSource > code; this allows simplifyin

Re: [VOTE] Release Apache Tomcat 9.0.39

2020-10-06 Thread Filip Hanik
[X] Stable - go ahead and release as 9.0.39 On Tue, Oct 6, 2020 at 07:49 Mark Thomas wrote: > The proposed Apache Tomcat 9.0.39 release is now available for voting. > > The notable changes compared to the 9.0.38 release are: > > - Refactor the handling of closed HTTP/2 streams to reduce the heap

Re: [VOTE] Release Apache Tomcat 8.5.59

2020-10-06 Thread Filip Hanik
[X] Stable - go ahead and release as 8.5.59 On Tue, Oct 6, 2020 at 10:34 Mark Thomas wrote: > The proposed Apache Tomcat 8.5.59 release is now available for voting. > > The notable changes compared to the 8.5.58 release are: > > - Refactor the handling of closed HTTP/2 streams to reduce the heap

Re: [VOTE] Release Apache Tomcat 10.0.0-M9

2020-10-06 Thread Filip Hanik
[X] Alpha - go ahead and release as 10.0.0-M9 On Tue, Oct 6, 2020 at 06:45 Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M9 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has cha

Re: Deprecated JDBCRealm

2020-09-14 Thread Filip Hanik
Easy choice. +1 On Mon, Sep 14, 2020 at 11:53 Mark Thomas wrote: > All, > > > > I'd like to proposed the following: > > - Deprecated the JDBCRealm in 7.0.x, 8.5.x and 9.0.x > > - Remove the JDBCRealm in 10.0.x > > > > The reasons for this are: > > - The JDBCRealm is single threaded > > - The Dat

Re: Plans for Servlet 5.1

2020-09-12 Thread Filip Hanik
On 9/10/20, 01:17, "Mark Thomas" wrote: Hi all, It looks like at least one of the specs Tomcat implements, Servlets, is going to have at least one release between Jakarta EE 9 / Servlet 5.0 / Tomcat 10.0 and Jakarta EE 10/ Servlet 6.0 / Tomcat 10.1 The current plan is for

Re: [VOTE] Release Apache Tomcat 10.0.0-M8

2020-09-12 Thread Filip Hanik
X] Alpha - go ahead and release as 10.0.0-M8 On 9/10/20, 05:57, "Keiichi Fujino" wrote: 2020年9月9日(水) 23:57 Mark Thomas : > The proposed Apache Tomcat 10.0.0-M8 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary

Re: [VOTE] Release Apache Tomcat 9.0.38

2020-09-12 Thread Filip Hanik
[X] Stable - go ahead and release as 9.0.38 On 9/10/20, 05:58, "Keiichi Fujino" wrote: 2020年9月10日(木) 18:03 Mark Thomas : > The proposed Apache Tomcat 9.0.38 release is now available for voting. > > The notable changes compared to the 9.0.37 release are: > > - For reques

Re: [VOTE] Release Apache Tomcat 8.5.58

2020-09-12 Thread Filip Hanik
[X] Stable - go ahead and release as 8.5.58 On 9/10/20, 15:10, "Mark Thomas" wrote: The proposed Apache Tomcat 8.5.58 release is now available for voting. The notable changes compared to the 8.5.57 release are: - For requests containing the Expect: 100-continue header, optiona

Re: Next release

2020-09-03 Thread Filip Hanik
On Thu, Sep 3, 2020 at 07:44 Mark Thomas wrote: > > > On 27/08/2020 14:15, Rémy Maucherat wrote: > > > On Thu, Aug 27, 2020 at 4:26 AM Filip Hanik > > <mailto:fi...@hanik.com>> wrote: > > > On Wed, Aug 26, 2020 at 12:12 Rémy Mauchera

Re: Next release

2020-08-26 Thread Filip Hanik
On Wed, Aug 26, 2020 at 12:12 Rémy Maucherat wrote: > On Wed, Aug 26, 2020 at 6:25 PM Filip Hanik wrote: > >> >> >> On Wed, Aug 26, 2020 at 09:15 Mark Thomas wrote: >> >>> On 26/08/2020 17:12, Filip Hanik wrote: >>> >>> > Our cadenc

Re: Next release

2020-08-26 Thread Filip Hanik
On Wed, Aug 26, 2020 at 09:15 Mark Thomas wrote: > On 26/08/2020 17:12, Filip Hanik wrote: > > > Our cadence seems fairly predictable. > > > > > > Any thoughts on the timeline of the on the next batch of releases? > > > > I skipped the August r

Next release

2020-08-26 Thread Filip Hanik
Our cadence seems fairly predictable. Any thoughts on the timeline of the on the next batch of releases? Filip

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-11 Thread Filip Hanik
+1 On Mon, Aug 10, 2020 at 08:46 Mark Thomas wrote: > Hi all, > > I'd like to propose removing all the functional spec pages from the > documentation web application. > > My reasoning for this proposal is, in short, that we aren't using or > maintaining these pages. > > I don't recall any discus

Re: [tomcat] 02/02: Avoid reflection for default instantiation

2020-07-24 Thread Filip Hanik
From: Martin Grigorov Sent: Wednesday, July 22, 2020 2:29 AM To: Tomcat Developers List Subject: Re: [tomcat] 02/02: Avoid reflection for default instantiation +public class AprStatus { +private static volatile boolean aprInitialized = false; +p

RE: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Filip Hanik
ge. If I understand it correctly, the substrate VM doesn't pick up those substitutions when running in Java mode. Filip > > Le mer. 22 juil. 2020 à 20:17, Filip Hanik <mailto:fha...@vmware.com> > a écrit : > > > Thanks Remy, > > > > I ra

Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Filip Hanik
Good idea, I’ll add that as a separate commit. On Wed, Jul 22, 2020 at 13:08 Rémy Maucherat wrote: > On Wed, Jul 22, 2020 at 8:17 PM Filip Hanik wrote: > >> Thanks Remy, >> >> >> >> I ran into some failures when running the test suite using the substra

RE: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Filip Hanik
r48%3D&reserved=0> The following commit(s) were added to refs/heads/master by this push: new 098c4c8 Simpler way to determine Graal runtime 098c4c8 is described below commit 098c4c81602ba1e8d5f33b0795d7caf55f70d573 Author: Filip Hanik mailto:fha...@pivotal.io>> AuthorDate:

RE: [tomcat] branch master updated: Avoid reflection for default instantiation

2020-07-22 Thread Filip Hanik
spic.AuthConfig > FactoryImpl")) > > { > > Why not use AuthConfigFactoryImpl.class.getName()? It may help in the > future with refactoring. [Filip Hanik] Trying to avoid a circular dependency. You see the javax/jakarta package should not import org.apache.catalina code

Re: Native Image - Reflectionless Concept

2020-07-21 Thread Filip Hanik
We've had some discussions around this, mostly high level about where this could go. At this point, anyone strongly opposed to ship a light weight jar? Do we feel the value is or is not there compared to the maintenance of it? Filip On 7/13/20 2:59 PM, Filip Hanik wrote: for discu

Re: Native Image - Reflectionless Concept

2020-07-20 Thread Filip Hanik
On 7/20/20 8:47 AM, Romain Manni-Bucau wrote: Le lun. 20 juil. 2020 à 17:41, Filip Hanik <mailto:fi...@hanik.com>> a écrit : Thanks for chiming in: On 7/16/20 6:46 AM, Romain Manni-Bucau wrote: Hi everyone, I think the generation is the sanest option since code s

Re: Native Image - Reflectionless Concept

2020-07-20 Thread Filip Hanik
16 juil. 2020 à 14:31, Rémy Maucherat <mailto:r...@apache.org>> a écrit : On Mon, Jul 13, 2020 at 11:59 PM Filip Hanik mailto:fha...@vmware.com>> wrote: for discussion, all feedback and questions welcome: I've created a concept of having Apache Tomcat, emb

Re: Native Image - Reflectionless Concept

2020-07-16 Thread Filip Hanik
Thanks for reviewing and engaging. On 7/16/20 5:31 AM, Rémy Maucherat wrote: On Mon, Jul 13, 2020 at 11:59 PM Filip Hanik <mailto:fha...@vmware.com>> wrote: for discussion, all feedback and questions welcome: I've created a concept of having Apache Tomcat, embedded, r

Native Image - Reflectionless Concept

2020-07-13 Thread Filip Hanik
for discussion, all feedback and questions welcome: I've created a concept of having Apache Tomcat, embedded, run without reflection in a native image. This concept creates a jar, tomcat-embedded-programmatic.jar, that can be fine tuned to only include what is needed in a default configuration

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Filip Hanik
{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?(\]|\)))|\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?` Thank you Ray, that was it! Filip - Ray On Tue, Jun 23, 2020 at 4:05 PM Raymond Auge <mailto:raymond.a...@liferay.com>> wrote: On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Filip Hanik
t.java:292) Filip - Ray On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik <mailto:fha...@vmware.com>> wrote: *From:* Raymond Auge mailto:raymond.a...@liferay.com>> *Sent:* Tuesday, June 23, 2020 12:17 PM *To:* Tomcat Developers List mailto:dev@tomcat.apache.org>> *Su

RE: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Filip Hanik
From: Raymond Auge Sent: Tuesday, June 23, 2020 12:17 PM To: Tomcat Developers List Subject: Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error k, so travis config is borked.. I should add github actions. I don’t think Travis tests artifact generation - Ray On Tue, Jun 23, 2020 at

RE: [tomcat] branch 9.0.x updated: Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks

2020-06-23 Thread Filip Hanik
is push: > new 919183b Make `ant -f mvn-pub.xml generic-install` work with > the new ant tasks 919183b is described below > > commit 919183b438e1a2f0004082c69e34accc0c3e2f16 > Author: Filip Hanik > AuthorDate: Tue Jun 23 11:11:24 2020 -0700 > > Make `ant -f mvn-pub.

RE: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Filip Hanik
From: Raymond Auge Sent: Tuesday, June 23, 2020 11:58 AM To: Tomcat Developers List Subject: Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error This is not a good fix. This is the same problem we had before with incompatible version syntax in OSGi - Ray Hi Ray, I can’t even build

Re: Remove org.apache.catalina.tribes.transport.bio

2020-04-29 Thread Filip Hanik
On 4/29/20 8:56 AM, Rémy Maucherat wrote: On Tue, Apr 28, 2020 at 7:18 PM Mark Thomas > wrote: On 28/04/2020 17:30, Rémy Maucherat wrote: > Hi, > > I'm still looking at things to remove or refactor in 10 following the > rearchitecting failure for

Re: Remove org.apache.catalina.tribes.transport.bio

2020-04-28 Thread Filip Hanik
On Tue, Apr 28, 2020 at 10:18 Mark Thomas wrote: > On 28/04/2020 17:30, Rémy Maucherat wrote: > > Hi, > > > > I'm still looking at things to remove or refactor in 10 following the > > rearchitecting failure for the Connector. One candidate could be the > > Tribes transport, since NIO is the defau

Re: [tomcat] branch 9.0.x updated (a7c132d -> 6ed7648)

2020-04-14 Thread Filip Hanik
Thanks Remy, I’ll run the validator and adjust accordingly On Tue, Apr 14, 2020 at 01:19 Rémy Maucherat wrote: > On Tue, Apr 14, 2020 at 1:50 AM wrote: > >> This is an automated email from the ASF dual-hosted git repository. >> >> fhanik pushed a change to branch 9.0.x >> in repository https

Re: API Change - Connector.java Constructor

2020-04-10 Thread Filip Hanik
On Fri, Apr 10, 2020 at 1:28 AM Rémy Maucherat wrote: > > >> This configuration gives the impression that the Endpoint is a child of >> the Connector. >> But the Connector truly only needs the ProtocolHandler interface to >> function. The injected object would then be better to an instance of a >

Graal Files for Embedded jar files (9.0.x)

2020-04-09 Thread Filip Hanik
I have this one for review. I would categorize it as a safe, since it doesn't affect backwards compatibility. This PR [1] has the following components 1. Changes to build script to include reflection and resources files in META-INF 2. The Graal configur

Re: API Change - Connector.java Constructor

2020-04-09 Thread Filip Hanik
Thanks Remy, On Wed, Apr 8, 2020 at 8:48 AM Rémy Maucherat wrote: > >> > If we want to improve on the Connector situation regarding duplication and > reflection abuse, the only solution is to expose the different objects > involved. > > Since an example is usually better, I'll give one using ser

Re: API Change - Connector.java Constructor

2020-04-07 Thread Filip Hanik
On Tue, Apr 7, 2020 at 9:35 AM Rémy Maucherat wrote: > >> Does the connector need to know about the actual implementations? >> > > Ideally no, but it removes the reflection you say is bad for Graal. > Correct. Turns out that the connectors use setProperty/getProperty via reflection (Introspectio

Re: API Change - Connector.java Constructor

2020-04-07 Thread Filip Hanik
On Tue, Apr 7, 2020 at 8:15 AM Rémy Maucherat wrote: > On Tue, Apr 7, 2020 at 10:16 AM Mark Thomas wrote: > >> > Noted, I think a compromise may be in order. Where we simply add a >> > constructor that avoids the Class.forName >> > and that allows the developer to explicitly invoke a constructor

Re: API Change - Connector.java Constructor

2020-04-06 Thread Filip Hanik
On Mon, Apr 6, 2020 at 11:20 AM Mark Thomas wrote: > On 06/04/2020 17:56, Filip Hanik wrote: > > Team, > > > > As I'm slowly transitioning between projects, Apache Tomcat has once > > again showed up in my workspace. I'm currently working on improving t

API Change - Connector.java Constructor

2020-04-06 Thread Filip Hanik
Team, As I'm slowly transitioning between projects, Apache Tomcat has once again showed up in my workspace. I'm currently working on improving the embedded experience for native images. I have a pull request, [1] , that I'd like to open up a discussion a

Re: Request line parsing

2020-03-23 Thread Filip Hanik
+1 Thorough and clear write up On Mon, Mar 23, 2020 at 06:01 Mark Thomas wrote: > Hi, > > I am currently looking at the request line parsing. I'll try and set out > each issue in turn. > > End of line parsing > === > > Prior to the recent changes, Tomcat allowed CRLF or LF to ma

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-23 Thread Filip Hanik
On Tue, Oct 23, 2018 at 7:05 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > Can I get a technical review for (a) appropriateness and (b) technical > implementation of the attached cluster interceptor? Let's assume for

Re: Tomcat JDBC Pool memory leak when using StatementFinalizer interceptor

2018-07-18 Thread Filip Hanik
ri, Jul 13, 2018 at 4:33 PM, Filip Hanik wrote: > > > >> hi Martin, > >> > >> On Fri, Jul 13, 2018 at 5:48 AM, Martin Knoblauch > >> wrote: > >> > >> > Hi, (moving to developers list) > >> > > >> > any ideas

Re: Tomcat JDBC Pool memory leak when using StatementFinalizer interceptor

2018-07-13 Thread Filip Hanik
hi Martin, On Fri, Jul 13, 2018 at 5:48 AM, Martin Knoblauch wrote: > Hi, (moving to developers list) > > any ideas on the problem below? This thing is kind of itching me :-) > > So I instrumented the "StatementFinalizer" class with some logging and > learned that over time a few instances of t

Re: svn commit: r1644737 - /tomcat/trunk/webapps/docs/config/systemprops.xml

2014-12-11 Thread Filip Hanik
Mr Schultz, nothing prevents you from removing the spaces if you at the same time fix the formatting or provide a solution to it. I do agree, that the spaces in the code for the sake of formatting is pretty lame, as it makes for erroneous copy/paste. On Thu, Dec 11, 2014 at 1:03 PM, Mark Thomas w

Re: Tomcat 9 work started

2014-11-03 Thread Filip Hanik
I honestly don't see the value of keeping BIO around. At this point in time, there can be little else other than an emotional attachment to it. As mentioned in this thread, the APIs and need for more functionality in the connectors have rendered the BIO connector obsolete. If we believe that a Tomc

Re: git (yet again)

2014-09-02 Thread Filip Hanik
On Tue, Sep 2, 2014 at 10:52 AM, Rémy Maucherat wrote: > 2014-09-02 18:41 GMT+02:00 Mark Thomas : > > > I'm leaning towards A myself. > ​ The move to git clears a huge hurdle, and that is managing contributions. The patch system is very difficult, and impossible to maintain. A pull request stays

Re: RFC6265, cookie parsing and UTF-8

2014-08-26 Thread Filip Hanik
On Tue, Aug 26, 2014 at 12:53 PM, Mark Thomas wrote: > One of the aims of the proposed cookie changes [1] was to deal with the > HTML 5 changes that mean UTF-8 can appear in cookie headers. > > This has some potentially large implications for Tomcat. > ​Since we already are in the 8.0.x release

Re: Coverity static analysis scanning

2014-08-26 Thread Filip Hanik
hook me up On Tuesday, August 26, 2014, Mark Thomas wrote: > All, > > I have been pinged off-list by Coverity to say that they have set up > Tomcat with a free account with their static code analysis service. > > I think I have the ability to send invitations so if anyone wants to > take a look

Re: [VOTE] Release Apache Tomcat 8.0.11

2014-08-18 Thread Filip Hanik
[X] Stable - go ahead and release as 8.0.11 Looks good over here. On Mon, Aug 18, 2014 at 8:28 AM, Mark Thomas wrote: > On 15/08/2014 21:07, Mark Thomas wrote: > > The proposed Apache Tomcat 8.0.11 release is now available for voting. > > > > The main changes since 8.0.9 are: > > - Various

Re: svn commit: r1616644 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementFinalizer.java

2014-08-10 Thread Filip Hanik
you are right, I will resolve it on Monday thanks for the review Filip On Sun, Aug 10, 2014 at 5:38 PM, Konstantin Kolinko wrote: > 2014-08-08 4:04 GMT+04:00 : > > Author: fhanik > > Date: Fri Aug 8 00:04:51 2014 > > New Revision: 1616644 > > > > URL: http://svn.apache.org/r1616644 > > Log:

Re: svn commit: r1616789 - /tomcat/trunk/modules/jdbc-pool/doc/changelog.xml

2014-08-10 Thread Filip Hanik
changelog was probably built when it was published by itself in the V1 days. we can move it to the main changelog, under jdbc-pool On Sun, Aug 10, 2014 at 3:42 PM, Konstantin Kolinko wrote: > 2014-08-08 18:53 GMT+04:00 : > > Author: fhanik > > Date: Fri Aug 8 14:53:06 2014 > > New Revision:

Re: svn commit: r1616584 - in /tomcat/trunk/modules/jdbc-pool: doc/ src/main/java/org/apache/tomcat/jdbc/naming/ src/main/java/org/apache/tomcat/jdbc/pool/

2014-08-10 Thread Filip Hanik
all looks good On Sun, Aug 10, 2014 at 9:04 AM, Konstantin Kolinko wrote: > 2014-08-08 0:15 GMT+04:00 : > > Author: fhanik > > Date: Thu Aug 7 20:15:19 2014 > > New Revision: 1616584 > > > > URL: http://svn.apache.org/r1616584 > > Log: > > Fix https://issues.apache.org/bugzilla/show_bug.cgi?i

Re: svn commit: r1613897 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java

2014-08-08 Thread Filip Hanik
On Mon, Jul 28, 2014 at 1:02 AM, wrote: > Author: kkolinko > Date: Mon Jul 28 07:02:31 2014 > New Revision: 1613897 > > URL: http://svn.apache.org/r1613897 > Log: > Revert generics changes from r1613123 > The code is compiled with Java 7, so why change them? > copy/paste mistake from the tc7.0.x

Re: [VOTE] Release Apache Tomcat 7.0.55

2014-07-22 Thread Filip Hanik
[X] Stable - go ahead and release as 7.0.55 Stable On Fri, Jul 18, 2014 at 6:47 PM, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.55 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.55/ > The Maven stagin

Re: [VOTE] Release Apache Tomcat 8.0.9

2014-06-19 Thread Filip Hanik
[X] Stable - go ahead and release as 8.0.9 (stable) On Thu, Jun 19, 2014 at 8:59 AM, Jeanfrancois Arcand wrote: > > >> The proposed 8.0.9 release is: >> [ ] Broken - do not release >> [ ] Alpha - go ahead and release as 8.0.9 (alpha) >> [ ] Beta - go ahead and release as 8.0.9 (beta) >> [X]

Re: NIO buffering

2014-04-23 Thread Filip Hanik
pping. On Wed, Apr 23, 2014 at 9:01 AM, Rémy Maucherat wrote: > 2014-04-23 16:50 GMT+02:00 Filip Hanik : > > > >I am not convinced by the NIO buffering that is used on output. > > > > what are you exactly referring to? Maybe I can shed some light on it. > > &

Re: NIO buffering

2014-04-23 Thread Filip Hanik
>I am not convinced by the NIO buffering that is used on output. what are you exactly referring to? Maybe I can shed some light on it. On Fri, Apr 18, 2014 at 1:30 PM, Rémy Maucherat wrote: > Hi, > > I am not convinced by the NIO buffering that is used on output. Due to > concurrent access iss

Re: Special requirements on session id generator

2014-02-14 Thread Filip Hanik
regardless of the use case, a debate whether to make something pluggable or extensible c(sh)ould be short. adding pluggability/extensibility that doesn't change default behavior can actually leave the exact use case out of the question. On Friday, February 14, 2014, Konstantin Preißer wrote: > H

Re: Removal of author tags in trunk

2014-01-24 Thread Filip Hanik
5 * @author Craig McClanahan >> 194 * @author Craig R. McClanahan >>2 * @author Craig R. McClanahan >>3 * @author Dan Milstein >> 18 * @author Dan Sandberg >>4 * @author Danno Ferrin >> 16 * @author David

RE: [VOTE] Apache Tomcat Maven plugin 2.2

2013-11-06 Thread Filip Hanik (mailing lists)
+1 > -Original Message- > From: Olivier Lamy [mailto:ol...@apache.org] > Sent: Wednesday, November 06, 2013 6:05 PM > To: Tomcat Developers List > Subject: [VOTE] Apache Tomcat Maven plugin 2.2 > > Hi, > I'd like to release Apache Tomcat Maven plugin 2.2. > > We fixed 22 issues. See > ht

RE: org.apache.tomcat.util.net.AbstractEndpoint#shutdownExecutor lasts 5s?

2013-11-06 Thread Filip Hanik (mailing lists)
"http-bio-1234-exec-19" daemon prio=10 tid=0x7fc30c014000 nid=0x5bb2 runnable [0x7fc31250f000] java.lang.Thread.State: RUNNABLE at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:152) at java.net.SocketInputStream.read(SocketIn

I'm back

2013-11-06 Thread Filip Hanik (mailing lists)
Ladies and Gentlemen, I'm back, it will take a little while to get up to speed on all changes but I intend to get involved again, so go easy on me while I learn the new tools of the trade ;) Filip - To unsubscribe, e-mail: dev-u

RE: org.apache.tomcat.util.net.AbstractEndpoint#shutdownExecutor lasts 5s?

2013-11-06 Thread Filip Hanik (mailing lists)
Romain, what you could do for a work around right now, is to set an executor yourself. This way, Tomcat won't attempt to stop it, and there wont be a delay. http://tomcat.apache.org/tomcat-7.0-doc/config/executor.html the only time tomcat attempts to stop the executor, is if it created it, but if

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
; > On 27/08/2012 22:48, Filip Hanik (mailing lists) wrote: > > > > > >> -Original Message- > >> From: Mark Thomas [mailto:ma...@apache.org] > >> Sent: Monday, August 27, 2012 3:44 PM > >> To: Tomcat Developers List > >> Su

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
; > On 27/08/2012 22:37, Filip Hanik (mailing lists) wrote: > >> -Original Message- > >> From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > >> Sent: Monday, August 27, 2012 2:09 PM > >> To: Tomcat Developers List > >> Subject: Re: s

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
r.java > > 2012/8/28 Filip Hanik (mailing lists) : > >> > >> There are documentation glitches yet to be fixed: > >> a. systemprops.xml change in trunk was not reverted by this commit. > >> It was reverted in 7.0.x only. > > [Filip Hanik] > >

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
gt; > or so. > > > >> 2. This turns it into a property on the listener > > > > Thanks. If the feature is retained, that is a much better > implementation. > > > > Re: 1: > Maybe somebody wants their full GC once an hour, or once a day? > > There

RE: pooledconnection & tccl?

2012-08-22 Thread Filip Hanik (mailing lists)
I've thought about this, you see if it is using TCCL it will cause a memory leak on app reload as the app wont be unloaded due to the pool holding it. But I think we should make it an option Best Filip > -Original Message- > From: Romain Manni-Bucau [mailto:rmannibu...@gmail.com] > Sent:

RE: tomat-jdbc & hashCode

2012-08-06 Thread Filip Hanik (mailing lists)
Fixed in r1370074 and r1370075 http://svn.apache.org/viewvc?rev=1370075&view=rev http://svn.apache.org/viewvc?rev=1370074&view=rev > -Original Message----- > From: Filip Hanik Mailing Lists [mailto:devli...@hanik.com] > Sent: Monday, July 30, 2012 5:58 AM > To: To

Re: tomat-jdbc & hashCode

2012-07-30 Thread Filip Hanik Mailing Lists
nope, I will fix that Filip - Original Message - > From: "Romain Manni-Bucau" > To: "Tomcat Developers List" > Sent: Tuesday, July 24, 2012 5:18:32 PM > Subject: tomat-jdbc & hashCode > > Hi, > > just noticed tomcat jdbc doesn't manage hashCode if the connection is > already close (it

RE: Unit tests and trunk

2012-07-18 Thread Filip Hanik (mailing lists)
; To: Tomcat Developers List > Subject: Re: Unit tests and trunk > > On 12/07/2012 02:05, Filip Hanik wrote: > > I can reproduce the bug in both our unit tests and the original bug > report. further more I can turn non blocking into blocking by opening an > clos

Re: svn commit: r1360729 - in /tomcat/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/

2012-07-15 Thread Filip Hanik Mailing Lists
st/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/ > > Do these patches need to be fed back to Commons DBCP? > > Or do they only apply to the version embedded by Tomcat? > > On 14 July 2012 21:47, Rainer Jung wrote: > > On 14.07.2012 22:25, Filip Hanik Mailing Lists w

Re: svn commit: r1360729 - in /tomcat/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/

2012-07-14 Thread Filip Hanik Mailing Lists
I know, it's the same patch for DBCP as for DBCP2. we can fix it, not urgent though - Original Message - > From: "Rainer Jung" > To: dev@tomcat.apache.org > Sent: Friday, July 13, 2012 3:47:27 AM > Subject: Re: svn commit: r1360729 - in /tomcat/trunk: ./ > modules/jdbc-pool/src/test/java/

Re: Current unit test behaviour for trunk using Java 7 on Solaris

2012-07-12 Thread Filip Hanik Mailing Lists
and properly fixed in http://svn.apache.org/viewvc?view=revision&revision=1360929 - Original Message - > From: "Filip Hanik (mailing lists)" > To: "Tomcat Developers List" > Sent: Thursday, July 12, 2012 2:43:55 PM > Subject: RE: Current unit test

RE: Current unit test behaviour for trunk using Java 7 on Solaris

2012-07-12 Thread Filip Hanik (mailing lists)
Fixed in http://svn.apache.org/viewvc?view=revision&revision=1360917 DBCP should compile as well as JDBC-POOL with 1.7 now too > -Original Message- > From: Rainer Jung [mailto:rainer.j...@kippdata.de] > Sent: Thursday, July 12, 2012 6:33 AM > To: Tomcat Developers List > Subject: Current

RE: svn commit: r1360905 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

2012-07-12 Thread Filip Hanik (mailing lists)
You are correct, I was chasing down the following: Testsuite: org.apache.catalina.websocket.TestWebSocket Tests run: 6, Failures: 1, Errors: 0, Time elapsed: 2.048 sec INFO: Starting ProtocolHandler ["http-nio-127.0.0.1-auto-2-9027"] Jul 12, 2012 11:56:27 AM org.apache.coyote.AbstractProtoco

RE: access to build environment

2012-07-12 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Thursday, July 12, 2012 1:33 AM > To: Tomcat Developers List > Subject: Re: access to build environment > > On 12/07/2012 02:06, Filip Hanik wrote: > > I'd guess those two, do we

Re: access to build environment

2012-07-11 Thread Filip Hanik
I'd guess those two, do we use anything else for tomcat ci? Sent from my iPhone On Jul 11, 2012, at 16:42, Mark Thomas wrote: > On 11/07/2012 23:40, Filip Hanik (mailing lists) wrote: >> How do I get access to the build environment? > > Which build environment? Gump, buil

Re: Unit tests and trunk

2012-07-11 Thread Filip Hanik
additional software layer. I'm sure there will be more bug reports as more people turn to java 7 on windows/hardware Sent from my iPhone On Jul 11, 2012, at 16:42, Mark Thomas wrote: > On 11/07/2012 23:30, Filip Hanik (mailing lists) wrote: >> I wasn't able to reproduce on a Win

access to build environment

2012-07-11 Thread Filip Hanik (mailing lists)
How do I get access to the build environment? So we can change the build to default to Java 7 Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
I opened a new issue pointing back to the old issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7183450. It may take a day or two before your bug shows up in this external database. > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]

  1   2   3   4   5   6   7   8   9   10   >