devjohnpark commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942968996
@markt-asf I agree that explicitly including the order in enum constant
names, like PHASE_0_NEW, enhances clarity without requiring HTTP/1.1 spec
knowledge. So I updated RequestLineParse
YongGoose commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942917295
@markt-asf
This is just a simple question out of curiosity — doesn’t the Tomcat project
use Copilot for code reviews?
I’m a committer for the Seata project, and I’ve found that C
YongGoose commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2942678690
> I'm not convinced. With `int` the order is clear and obvious. With the
proposed `enum` the correct order is less clear and depends on the reader
knowing the detail of the HTTP/1.1 spec f
Chenjp opened a new pull request, #865:
URL: https://github.com/apache/tomcat/pull/865
It is not suitable to encode session id in URL if client support cookie.
per discuss in #862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
https://bz.apache.org/bugzilla/show_bug.cgi?id=69706
--- Comment #3 from Christopher Schultz ---
+1 for just using an Integer which can be null.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To uns
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/37/builds/1422
Blamelist: Chenjp , Mark Thomas , Markus
Hoffrogge
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch 9.0.x] 6a944854ff95cc39f5ad7342a1411349e33
Build status: BUILD FAILED: failed Snapshot deployed to ASF Maven snapshot
repository (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/44/builds/1770
Blamelist: Mark Thomas , Markus Hoffrogge
Build Text: failed Snapshot deployed to ASF Maven snapshot repository (fai
On 04/06/2025 13:05, schu...@apache.org wrote:
Author: schultz
Date: Wed Jun 4 12:05:18 2025
New Revision: 1926115
URL: http://svn.apache.org/viewvc?rev=1926115&view=rev
Log:
Fix release date (year) for tcnative 2.0.9
Tx for fixing that.
Mark
---
https://bz.apache.org/bugzilla/show_bug.cgi?id=69706
--- Comment #2 from Remy Maucherat ---
Created attachment 40043
--> https://bz.apache.org/bugzilla/attachment.cgi?id=40043&action=edit
Patch for review
--
You are receiving this mail because:
You are the assignee for the bug.
--
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 1c2dfffc07 Remove trailing space
1c2dfffc07 is de
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 6a944854ff Remove trailing space
6a944854ff is desc
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 2c5a2bb008 Remove trailing space
2c5a2bb008 is de
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 91155c77e7 Remove trailing space
91155c77e7 is descri
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 8659c63624 FollowUp on Improve CVE-2024-56337 protect
Build status: BUILD FAILED: failed compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/37/builds/1421
Blamelist: Mark Thomas
Build Text: failed compile (failure)
Status Detected: new failure
Build Source Stamp: [branch 9.0.x] 793291e482022219d1c6032d1ffae9fcd916d
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 7b9426eea6 Do what the comment says - keep option
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new f07fedca37 FollowUp on Improve CVE-2024-56337 pro
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 076cd7a44e FollowUp on Improve CVE-2024-56337 pro
https://bz.apache.org/bugzilla/show_bug.cgi?id=69706
--- Comment #1 from Remy Maucherat ---
Looking at the commit, maybe the API change needs to be reverted. It is
possible to add a boolean to determine if the value has been explicitly set
instead (or use an Integer).
--
You are receiving this
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 28af7886b5 Add changelog entry
28af7886b5 is descri
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 52e5a885c42f664c5c2b93b79ee82c41dd1ae6e1
Author: Markus Hoffrogge
AuthorDate: Tue May 20 20:50:44 2025 +0200
Improve
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 159cdc8856cfd45524356a58e53991bf72ece8e7
Author: Markus Hoffrogge
AuthorDate: Wed May 21 12:27:01 2025 +0200
Update p
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit db8d3b4330d16d3be10a54d0084f199c99b68fff
Author: Markus Hoffrogge
AuthorDate: Tue May 20 17:21:54 2025 +0200
FollowUp
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from 4e86315dc1 Make comments consistent. Add changelog entry.
new db8d3b4330 FollowUp on Improve CVE-2024-56337 protect
markt-asf merged PR #858:
URL: https://github.com/apache/tomcat/pull/858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new f830b9f96c Make comments consistent. Add changelo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 4e86315dc1 Make comments consistent. Add changelog
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new b57d7e875c Make comments consistent. Add changelo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 19a240ae13 follow valid text rewrite map file synt
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 289fade4d2 follow valid text rewrite map file syntax
markt-asf merged PR #863:
URL: https://github.com/apache/tomcat/pull/863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
https://bz.apache.org/bugzilla/show_bug.cgi?id=69706
Bug ID: 69706
Summary: Session persistence broken when persistAuthentication
is turned on in tomcat 11.0.7
Product: Tomcat 11
Version: unspecified
Hardware: All
markt-asf commented on PR #855:
URL: https://github.com/apache/tomcat/pull/855#issuecomment-2939822823
I'm not convinced. With `int` the order is clear and obvious. With the
proposed `enum` the correct order is less clear and depends on the reader
knowing the detail of the HTTP/1.1 spec for
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 84cd7ada98b91b7e5b5689537240b0b566ef8c5b
Author: Mark Thomas
AuthorDate: Wed Jun 4 11:57:43 2025 +0100
Update Checksty
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from d54e8e0a4c Correct the hash (copy/paste error)
new aad9fd259a Update EasyMock to 5.6.0
new 84cd7ada98 Update Ch
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 1d9c2a56dd Update Checkstyle to 10.25.0
1d9c2a56d
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 17a8feb006 Update EasyMock to 5.6.0
17a8feb006 is d
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 793291e482 Update Checkstyle to 10.25.0
793291e482
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 9ea7c0246b Update Checkstyle to 10.25.0
9ea7c0246
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 09b25679b4 Update EasyMock to 5.6.0
09b25679b4 is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new c52f9fefca Update EasyMock to 5.6.0
c52f9fefca is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit aad9fd259a0baac1d8a6e9e1e212893e9902cf2e
Author: Mark Thomas
AuthorDate: Wed Jun 4 11:54:29 2025 +0100
Update EasyMock
Author: schultz
Date: Wed Jun 4 12:05:18 2025
New Revision: 1926115
URL: http://svn.apache.org/viewvc?rev=1926115&view=rev
Log:
Fix release date (year) for tcnative 2.0.9
Modified:
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/xdocs/index.xml
Modified: tomcat/site/trunk/docs/index
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-native.git
The following commit(s) were added to refs/heads/main by this push:
new 82c308fd4 Add note about needing a C compile
On Wed, Jun 4, 2025 at 12:47 PM Mark Thomas wrote:
>
> Hi all,
>
> My current plan for 11.0.8 is to tag towards the end of this week. There
> are a few PRs to review, I need to do the usual dependency checks and
> i18n updates as well as a couple of fixes I have sat locally that I need
> to clean
Hi all,
My current plan for 11.0.8 is to tag towards the end of this week. There
are a few PRs to review, I need to do the usual dependency checks and
i18n updates as well as a couple of fixes I have sat locally that I need
to clean up and commit.
Mark
---
markt-asf commented on PR #864:
URL: https://github.com/apache/tomcat/pull/864#issuecomment-2939391552
Potential security vulnerabilities **DO NOT** belong in public pull requests.
Guidance on how to report security vulnerabilities responsibly can be found
at:
https://tomcat.apache
markt-asf closed pull request #864: fix arbitrary file access during archive
extraction zipslip
URL: https://github.com/apache/tomcat/pull/864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
cur1pro opened a new pull request, #864:
URL: https://github.com/apache/tomcat/pull/864
To fix the issue, we need to ensure that paths derived from
`entry.getName()` are validated to prevent directory traversal attacks. This
involves:
1. Normalizing the path using `java.nio.file.
Chenjp commented on PR #862:
URL: https://github.com/apache/tomcat/pull/862#issuecomment-2939202088
> @Chenjp You should look carefully at the implementation of
`encodeRedirectURL()` before you comment further.
en...Current implementation checks session id source(COOKIES or
PathParam
rmaucher commented on PR #862:
URL: https://github.com/apache/tomcat/pull/862#issuecomment-2939013231
Servlet containers have to implement that (very complex) helper method that
does everything to achieve session tracking, depending on how the session
tracking was sent by the client, and th
markt-asf commented on PR #862:
URL: https://github.com/apache/tomcat/pull/862#issuecomment-2938933585
@Chenjp You should look carefully at the implementation of
`encodeRedirectURL()` before you comment further.
--
This is an automated message from the Apache Git Service.
To respond to t
52 matches
Mail list logo
