Re: [PR] fix BZ69492, Conditional requests comply rfc9110 [tomcat]

Chenjp commented on code in PR #796: URL: https://github.com/apache/tomcat/pull/796#discussion_r1879213975 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -2092,36 +2139,51 @@ protected boolean checkSendfile(HttpServletRequest request, HttpServletResponse p

Re: [PR] fix BZ69492, Conditional requests comply rfc9110 [tomcat]

Chenjp commented on code in PR #796: URL: https://github.com/apache/tomcat/pull/796#discussion_r1879094689 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -726,10 +727,79 @@ protected void doDelete(HttpServletRequest req, HttpServletResponse resp) throws *

Re: [PR] fix BZ69492, Conditional requests comply rfc9110 [tomcat]

rmaucher commented on code in PR #796: URL: https://github.com/apache/tomcat/pull/796#discussion_r1878573149 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -726,10 +727,79 @@ protected void doDelete(HttpServletRequest req, HttpServletResponse resp) throws

Re: Future of JNI in Tomcat

On Tue, Dec 10, 2024 at 1:01 PM Rainer Jung wrote: > > Am 12.09.24 um 16:15 schrieb Rémy Maucherat: > > This JEP has the potential to have a significant impact with Tomcat's > > JNI use starting with Java 26. > > https://openjdk.org/jeps/471 > > > > Unsafe.invokeCleaner will be removed, which will

Buildbot failure in on tomcat-9.0.x

Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/1211 Blamelist: remm Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x] 972e33b95f1de447084b86e0f1076e43506857bd S

(tomcat) branch 9.0.x updated: Add javadoc about the warning

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 972e33b95f Add javadoc about the warning 972e33b95f

(tomcat) branch 11.0.x updated: Add javadoc about the warning

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new ed62a24e73 Add javadoc about the warning ed62a24e7

(tomcat) branch 10.1.x updated: Add javadoc about the warning

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 05d5ad90c0 Add javadoc about the warning 05d5ad90c

(tomcat) branch main updated: Add javadoc about the warning

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 23f2d1a864 Add javadoc about the warning 23f2d1a864 is

Re: Future of JNI in Tomcat

Am 12.09.24 um 16:15 schrieb Rémy Maucherat: This JEP has the potential to have a significant impact with Tomcat's JNI use starting with Java 26. https://openjdk.org/jeps/471 Unsafe.invokeCleaner will be removed, which will effectively prevent using the direct ByteBuffers that are needed for tom

Re: [PR] fix BZ69492, Conditional requests comply rfc9110 [tomcat]

rmaucher commented on code in PR #796: URL: https://github.com/apache/tomcat/pull/796#discussion_r1877944306 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -718,18 +719,89 @@ protected void doDelete(HttpServletRequest req, HttpServletResponse resp) throws

Re: [PR] fix BZ69492, Conditional requests comply rfc9110 [tomcat]

Chenjp commented on code in PR #796: URL: https://github.com/apache/tomcat/pull/796#discussion_r1877937586 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -718,18 +719,89 @@ protected void doDelete(HttpServletRequest req, HttpServletResponse resp) throws *

Re: [PR] fix BZ69492, Conditional requests comply rfc9110 [tomcat]

Chenjp commented on code in PR #796: URL: https://github.com/apache/tomcat/pull/796#discussion_r1877684200 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -718,18 +719,89 @@ protected void doDelete(HttpServletRequest req, HttpServletResponse resp) throws *

Re: [PR] fix BZ69492, Conditional requests comply rfc9110 [tomcat]

rmaucher commented on code in PR #796: URL: https://github.com/apache/tomcat/pull/796#discussion_r1877654377 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -718,18 +719,89 @@ protected void doDelete(HttpServletRequest req, HttpServletResponse resp) throws

[PR] fix BZ69492, Conditional requests comply rfc9110 [tomcat]

Chenjp opened a new pull request, #796: URL: https://github.com/apache/tomcat/pull/796 1. preconditions evaluation implementation comply spec, as rfc 9110 section 13.2.2. defined. 2. fix BZ69492; 3. since resource etag and lastmodified are used often during checkIfXXX, then make th