rmaucher commented on code in PR #796:
URL: https://github.com/apache/tomcat/pull/796#discussion_r1877654377
##########
java/org/apache/catalina/servlets/DefaultServlet.java:
##########
@@ -718,18 +719,89 @@ protected void doDelete(HttpServletRequest req,
HttpServletResponse resp) throws
* @param request The servlet request we are processing
* @param response The servlet response we are creating
* @param resource The resource
+ * @param resourceETag The resource etag
+ * @param resourceLastModified The last modification time in milliseconds
of the resource, -1 if not available.
*
* @return <code>true</code> if the resource meets all the specified
conditions, and <code>false</code> if any of
* the conditions is not satisfied, in which case request
processing is stopped
*
* @throws IOException an IO error occurred
*/
- protected boolean checkIfHeaders(HttpServletRequest request,
HttpServletResponse response, WebResource resource)
- throws IOException {
-
- return checkIfMatch(request, response, resource) &&
checkIfModifiedSince(request, response, resource) &&
- checkIfNoneMatch(request, response, resource) &&
checkIfUnmodifiedSince(request, response, resource);
+ protected boolean checkIfHeaders(HttpServletRequest request,
HttpServletResponse response, WebResource resource,
+ String resourceETag, long resourceLastModified) throws IOException
{
Review Comment:
-1 for the API change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
