Hey Mark,
Thank you for the input. I believe that such a feature will be extremely
helpful as well, on top of the queue time.
1. I was thinking - if we want to accurately capture the time taken by the
Poller (only the poller, which excludes the time taken after accepting
connections.) in reading
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/37/builds/1196
Blamelist: Mark Thomas , remm
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch 9.0.x] 3315a9027a7eaab18f42625b97b569940ff1365d
Steps:
work
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 8158309843 Obfuscate session cookie values for JSON o
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 8769fefd0937aba06203c1cd4b1d257bf6b5db93
Author: Mark Thomas
AuthorDate: Mon Dec 2 15:36:59 2024 +
Remove out of
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit c9c80c782a30c15e3c6aac621972f9f127b71c01
Author: Mark Thomas
AuthorDate: Mon Dec 2 15:30:46 2024 +
Fix return and
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new f57a9d9847 Obfuscate session cookie values for JS
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 4f02366069 Obfuscate session cookie values for JS
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from faee322fb9 Code clean-up - formatting. No functional change
new 581b256573 Fix return and code links when request
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 0c80b155a0b0fdd344eda035c979ab03389e7547
Author: Mark Thomas
AuthorDate: Mon Dec 2 15:36:59 2024 +
Remove out of
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 64abd533ab Code clean-up - formatting. No functio
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 3e8199017ee9c37a7579a571ca3c2f3c442fcbc4
Author: Mark Thomas
AuthorDate: Mon Dec 2 15:36:59 2024 +
Remove out of d
https://bz.apache.org/bugzilla/show_bug.cgi?id=65391
--- Comment #3 from Chuck Caldarale ---
(In reply to Christopher Schultz from comment #2)
> (In reply to Mark Thomas from comment #1)
> > Fixed in https://github.com/apache/tomcat/pull/463 for 10.1.0-M11 onwards
>
> Uhh... what version is that
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit fed4ac65c7943368138c0b13613454e214314b99
Author: Mark Thomas
AuthorDate: Mon Dec 2 15:30:46 2024 +
Fix return an
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from 64abd533ab Code clean-up - formatting. No functional change
new fed4ac65c7 Fix return and code links when request
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from 5adf342f83 Code clean-up - formatting. No functional change
new c9c80c782a Fix return and code links when request U
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new faee322fb9 Code clean-up - formatting. No functio
Rémy,
On 12/2/24 9:56 AM, Rémy Maucherat wrote:
I saw that this was not tested at all, so I had a look at it.
Are there any uses of this ? If there are, I think this should be
rewritten as a generic access logger like the JSON one, using a
DataSource like all the other Tomcat components. Right
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit dae91ff3bc56127c3d897a5d6af2f1289c941952
Author: Mark Thomas
AuthorDate: Mon Dec 2 15:30:46 2024 +
Fix return and
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new e8c16cdba8 Add a limit of 10 attributes per sessi
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 3315a9027a Fix backprot
3315a9027a is described bel
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 84065e26ca Add a limit of 10 attributes per session
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 87f3134b6b Add a limit of 10 attributes per session t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new b1f65728b3 Add a limit of 10 attributes per sessi
https://bz.apache.org/bugzilla/show_bug.cgi?id=65391
--- Comment #2 from Christopher Schultz ---
(In reply to Mark Thomas from comment #1)
> Fixed in https://github.com/apache/tomcat/pull/463 for 10.1.0-M11 onwards
Uhh... what version is that, again?
--
You are receiving this mail because:
You
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 721544ea28 Add the ability to delete session attrib
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new c0a23927ea Add the ability to delete session attr
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new aa5b4d0043 Add the ability to delete session attr
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 18ffbac13f Add the ability to delete session attribut
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 40069ceee7dd070dc7f95ec04c45b6b5324a83c6
Author: Mark Thomas
AuthorDate: Mon Dec 2 15:36:59 2024 +
Remove out of
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 1d88dd3ffa Obfuscate session cookie values for JSON
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 581b256573a0756d33bc5e9440eabd2381d55581
Author: Mark Thomas
AuthorDate: Mon Dec 2 15:30:46 2024 +
Fix return an
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from 4ffed205f8 Code clean-up - formatting. No functional change
new dae91ff3bc Fix return and code links when request UR
Chenjp opened a new pull request, #792:
URL: https://github.com/apache/tomcat/pull/792
add CRLF after the last-chunk to build a valid chunked request body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Hi,
I saw that this was not tested at all, so I had a look at it.
Are there any uses of this ? If there are, I think this should be
rewritten as a generic access logger like the JSON one, using a
DataSource like all the other Tomcat components. Right now, it
pretends to do common or combined patt
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 5adf342f83 Code clean-up - formatting. No functiona
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/1421
Blamelist: Mark Thomas , remm
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch 11.0.x] 4a9347122b55220d27ecf3c06d976ad08f8411f8
Steps:
wo
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 4ffed205f8 Code clean-up - formatting. No functional
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 9b337ff595 Test improvement
9b337ff595 is describe
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 7322033c8e Test improvement
7322033c8e is described
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new ba2ec3e46e Test improvement
ba2ec3e46e is describe
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new c5e5ec5b7f Test improvement
c5e5ec5b7f is described be
On Mon, Dec 2, 2024 at 1:03 PM wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
> new
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/120/builds/249
Blamelist: Mark Thomas , remm
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch main] 537adeb861e06ec582db67c7a9e42f43a971efda
Steps:
worke
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new ac87406b10 Try and fix CI failures
ac87406b10 is de
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 3200e61f4b Try and fix CI failures
3200e61f4b is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 4a9347122b Try and fix CI failures
4a9347122b is
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 537adeb861 Try and fix CI failures
537adeb861 is desc
Andy,
I think you are missing a chunk of time with this approach. I'd look at
recording time on the SocketWrapper when the connection is accepted. Or
at least something along those lines. I haven;t looked too carefully at
the code to see what might be possible. That way you'll also capture the
Hi Mark,
Apologies for sending you an email again, could I ask for a quick review on
how I made this feature work to see if I have any misconceptions, which
could affect how I would code it in Tomcat's source code? On top of the
queue time, I added the request processing time as well as I wanted t
49 matches
Mail list logo
