Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]

2024-09-12 Thread via GitHub
Chenjp commented on code in PR #751: URL: https://github.com/apache/tomcat/pull/751#discussion_r1758003371 ## java/org/apache/tomcat/util/http/FastHttpDateFormat.java: ## @@ -104,8 +104,9 @@ public final class FastHttpDateFormat { */ public static String getCurrentDat

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #14 from Konstantin Kolinko --- (In reply to elatllat from comment #10) > (In reply to Mark Thomas from comment #6) > > Release votes are announced on the dev list. > > I'm not seeing anything relevant: > > https://lists.apache.or

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #13 from Mark Thomas --- I'm seeing something similar. Running the h2spec test suite seems to trigger the bad state reliably. Next step is to use git bisect to figure out where the problem was introduced. Once we know which commit i

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #12 from elatl...@gmail.com --- I can trigger this issue just by reloading a page with ~40 assets. I can not trigger it on a page with 5 assets. Once the issue is triggered it manifests on pages with 5 assets (2 to 4 of 5 will fail)

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #11 from elatl...@gmail.com --- Created attachment 39866 --> https://bz.apache.org/bugzilla/attachment.cgi?id=39866&action=edit curl log -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #10 from elatl...@gmail.com --- (In reply to Mark Thomas from comment #6) > Release votes are announced on the dev list. I'm not seeing anything relevant: https://lists.apache.org/list?dev@tomcat.apache.org:release%20candidate: Pl

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #9 from Mark Thomas --- The errors I am seeing on the rare occasions I am able to reproduce what I think is this new error suggest an issue with header processing. The stack trace in the attachment looks like the result of the clie

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #8 from EJ Egyed --- I am experiencing an error I believe is related on 9.0.94. After reverting to 9.0.93 the error went away. I am not sure how to reproduce the error, but was seeing errors written to the catalina log file. Attache

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #7 from EJ Egyed --- Created attachment 39865 --> https://bz.apache.org/bugzilla/attachment.cgi?id=39865&action=edit Catalina log file -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #6 from Mark Thomas --- Release votes are announced on the dev list. It appears that this bug is harder to reproduce that it first appeared. I've seen in - or something that might be it - with 10.1.x and 11.0.x but not 9.0.x and I

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #5 from elatl...@gmail.com --- (In reply to Mark Thomas from comment #4) > I'll note that bugs that get reported during the release vote nearly always > result in the vote being cancelled, the bug being fixed and a new release > vote

Re: [PR] Add ParameterLimitValve to enforce request parameter limits for specific URLs [tomcat]

2024-09-12 Thread via GitHub
markt-asf commented on PR #753: URL: https://github.com/apache/tomcat/pull/753#issuecomment-2346801534 This approach could be implemented as a Filter. If we were going to do this, I think something that enforces the limit at the point the parameters are parsed - rather than after - is the w

Re: Future of JNI in Tomcat

2024-09-12 Thread Mark Thomas
On 12/09/2024 15:15, Rémy Maucherat wrote: Hi, This JEP has the potential to have a significant impact with Tomcat's JNI use starting with Java 26. https://openjdk.org/jeps/471 Unsafe.invokeCleaner will be removed, which will effectively prevent using the direct ByteBuffers that are needed for

Possible HTTP/2 regression in Sept releases

2024-09-12 Thread Mark Thomas
See BZ 69320. I've reproduced the issue on 10.1.x. Haven't tested other versions yet or started to look for a root cause. That is next. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands,

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #4 from Mark Thomas --- I'll note that bugs that get reported during the release vote nearly always result in the vote being cancelled, the bug being fixed and a new release vote. To put it another way, test the release candidate du

Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]

2024-09-12 Thread via GitHub
markt-asf commented on code in PR #751: URL: https://github.com/apache/tomcat/pull/751#discussion_r1757204766 ## java/org/apache/tomcat/util/http/FastHttpDateFormat.java: ## @@ -104,8 +104,9 @@ public final class FastHttpDateFormat { */ public static String getCurrent

Future of JNI in Tomcat

2024-09-12 Thread Rémy Maucherat
Hi, This JEP has the potential to have a significant impact with Tomcat's JNI use starting with Java 26. https://openjdk.org/jeps/471 Unsafe.invokeCleaner will be removed, which will effectively prevent using the direct ByteBuffers that are needed for tomcat-native. The solution is to use a memor

(tomcat) branch 9.0.x updated: Tests the compatibility with rewrite from httpd for non existent headers

2024-09-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f035e6a278 Tests the compatibility with rewrite from

(tomcat) branch 10.1.x updated: Tests the compatibility with rewrite from httpd for non existent headers

2024-09-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 6bb7babff4 Tests the compatibility with rewrite fr

(tomcat) branch 11.0.x updated: Tests the compatibility with rewrite from httpd for non existent headers

2024-09-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 904b6e79ed Tests the compatibility with rewrite fr

(tomcat) 01/01: Merge pull request #752 from PaulLodge/httpd-rewrite-non-existent-header

2024-09-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 67dc904530a42aeaca0b5c6af3dbb6f61e68917a Merge: eec1b2347a 98b4e8d35c Author: Rémy Maucherat AuthorDate: Thu Sep 12 15:38:11

(tomcat) branch main updated (eec1b2347a -> 67dc904530)

2024-09-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from eec1b2347a Remove unused code add 98b4e8d35c Tests the compatibility with rewrite from httpd for non existent header

Re: [PR] Tests the compatibility with rewrite from httpd for non existent headers [tomcat]

2024-09-12 Thread via GitHub
rmaucher merged PR #752: URL: https://github.com/apache/tomcat/pull/752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or

[PR] Add ParameterLimitValve to enforce request parameter limits for specific URLs [tomcat]

2024-09-12 Thread via GitHub
dsoumis opened a new pull request, #753: URL: https://github.com/apache/tomcat/pull/753 This is an effort of introducing Parameter Limit Valve to allow limiting the number of parameters in HTTP requests, but explicitly allowing more parameters for specific URLs. It's worth to be note

Re: [PR] Tests the compatibility with rewrite from httpd for non existent headers [tomcat]

2024-09-12 Thread via GitHub
n828cl commented on PR #752: URL: https://github.com/apache/tomcat/pull/752#issuecomment-2346272595 The new method testRewriteEmptyHeader() does not appear to be invoked from anywhere. Is some of the change missing? -- This is an automated message from the Apache Git Service. To respond t

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #3 from elatl...@gmail.com --- Please let me know what "supporting information" I can share. This regression is not happening in any other 10.x build. The last log line is just 12-Sep-2024 08:46:35.076 INFO [main] org.apache.catali

[PR] Tests the compatibility with rewrite from httpd for non existent headers [tomcat]

2024-09-12 Thread via GitHub
PaulLodge opened a new pull request, #752: URL: https://github.com/apache/tomcat/pull/752 This test adds code coverage for CVE-2010-3718, I noticed it was missing from the code coverage, the fix also contains a very small code refactor that allows the test to work. -- This is an automate

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #2 from elatl...@gmail.com --- I sent an email to us...@infra.apache.org because commenting on this bug is producing a bug (Too many connections at /usr/lib/x86_64-linux-gnu/perl5/5.34/DBI.pm line 691.) -- You are receiving this ma

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 --- Comment #1 from Chuck Caldarale --- Without some useful supporting information, this will be closed as WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 69320] ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 elatl...@gmail.com changed: What|Removed |Added Priority|P2 |P5 Severity|normal

[Bug 69320] New: ERR_HTTP2_PROTOCOL_ERROR

2024-09-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69320 Bug ID: 69320 Summary: ERR_HTTP2_PROTOCOL_ERROR Product: Tomcat 10 Version: 10.1.29 Hardware: PC OS: Linux Status: NEW Severity: normal Priori

(tomcat) branch 10.1.x updated: Remove unused code

2024-09-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 730310c69b Remove unused code 730310c69b is descri

(tomcat) branch 11.0.x updated: Remove unused code

2024-09-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new e34c8f6b9b Remove unused code e34c8f6b9b is descri

(tomcat) branch main updated: Remove unused code

2024-09-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new eec1b2347a Remove unused code eec1b2347a is described

Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]

2024-09-12 Thread via GitHub
Chenjp commented on code in PR #751: URL: https://github.com/apache/tomcat/pull/751#discussion_r1756465922 ## java/org/apache/tomcat/util/http/FastHttpDateFormat.java: ## @@ -104,8 +104,9 @@ public final class FastHttpDateFormat { */ public static String getCurrentDat

Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]

2024-09-12 Thread via GitHub
markt-asf commented on code in PR #751: URL: https://github.com/apache/tomcat/pull/751#discussion_r1756307644 ## java/org/apache/tomcat/util/http/FastHttpDateFormat.java: ## @@ -104,8 +104,9 @@ public final class FastHttpDateFormat { */ public static String getCurrent