Re: Performance improvements for HTTP/2

2024-07-23 Thread Mark Thomas
On 23/07/2024 21:30, Christopher Schultz wrote: Mark, On 7/23/24 13:13, Mark Thomas wrote: Prompted by some folks at $dayjob, I have been looking at the performance of Tomcat's HTTP/2 implementation using [1] Initially, I was seeing ~79k req/s. Restoring lazy init for the StreamInputBuffer i

Re: TCK CI runs

2024-07-23 Thread Mark Thomas
On 23/07/2024 23:38, Christopher Schultz wrote: On 7/23/24 03:05, Mark Thomas wrote: Given that we are free to make factual statements such as "Tomcat 11.0.x passes the latest Annotations, EL, Pages, Servlet and WebSocket TCKs" or "Tomcat 11.0.0-M20 is a compatible implementation of the Ja

[Bug 69216] META-INF/services is missing from tomcat-embed-el

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69216 --- Comment #2 from gabriel.din...@migrosonline.ch --- Awesome, thanks for the fix Remy ;-). -- You are receiving this mail because: You are the assignee for the bug. - To uns

Re: TCK CI runs

2024-07-23 Thread Christopher Schultz
Mark, On 7/23/24 03:05, Mark Thomas wrote: On 22/07/2024 23:33, Christopher Schultz wrote: Mark, On 7/22/24 12:53, Mark Thomas wrote: All, Today I have configured the tomcat-tck repository to run the EL, Servlet, Pages and WebSocket TCKs once every day for all combinations of JDK 17 & 21,

Re: [VOTE] Release Apache Tomcat Native 2.0.8

2024-07-23 Thread Christopher Schultz
Mark, Thanks for RMing. On 7/17/24 15:51, Mark Thomas wrote: The key differences of version 2.0.8 compared to 2.0.7 are: - Fix a crash on Windows when SSLContext.setCACertificate() is invoked   with a null value for caCertificateFile and a non-null value for   caCertificatePath - The windows

Re: Performance improvements for HTTP/2

2024-07-23 Thread Christopher Schultz
Mark, On 7/23/24 13:13, Mark Thomas wrote: Prompted by some folks at $dayjob, I have been looking at the performance of Tomcat's HTTP/2 implementation using [1] Initially, I was seeing ~79k req/s. Restoring lazy init for the StreamInputBuffer increased that to ~106k req/s. O_O Moving the

Re: Performance improvements for HTTP/2

2024-07-23 Thread Rémy Maucherat
On Tue, Jul 23, 2024 at 7:15 PM Mark Thomas wrote: > > Prompted by some folks at $dayjob, I have been looking at the > performance of Tomcat's HTTP/2 implementation using [1] > > Initially, I was seeing ~79k req/s. > > Restoring lazy init for the StreamInputBuffer increased that to ~106k req/s. >

Re: TCK CI runs

2024-07-23 Thread Mark Thomas
On 23/07/2024 15:33, Christopher Schultz wrote: I just meant kinda being able to run a single command to do all the things, including fetch the release to be tested. I haven't checked-out the tomcat-tck project to test; maybe you've already done that. But if the first step of the instruction

Performance improvements for HTTP/2

2024-07-23 Thread Mark Thomas
Prompted by some folks at $dayjob, I have been looking at the performance of Tomcat's HTTP/2 implementation using [1] Initially, I was seeing ~79k req/s. Restoring lazy init for the StreamInputBuffer increased that to ~106k req/s. Moving the HttpParser from Processor to Protocol increased that

Re: [VOTE] Release Apache Tomcat Native 1.3.1

2024-07-23 Thread Christopher Schultz
Mark, Thanks for RMing. On 7/18/24 06:00, Mark Thomas wrote: The key differences compared to 1.3.0 are: - Fix a crash on Windows when SSLContext.setCACertificate() is invoked   with a null value for caCertificateFile and a non-null value for   caCertificatePath - The windows binaries in this

[Bug 69216] META-INF/services is missing from tomcat-embed-el

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69216 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: TCK CI runs

2024-07-23 Thread Christopher Schultz
Mark, On 7/23/24 03:05, Mark Thomas wrote: On 22/07/2024 23:33, Christopher Schultz wrote: Mark, On 7/22/24 12:53, Mark Thomas wrote: All, Today I have configured the tomcat-tck repository to run the EL, Servlet, Pages and WebSocket TCKs once every day for all combinations of JDK 17 & 21,

[Bug 69216] META-INF/services is missing from tomcat-embed-el

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69216 gabriel.din...@migrosonline.ch changed: What|Removed |Added Summary|META-INT/services is|META-INF/services is

[Bug 69216] New: META-INT/services is missing from tomcat-embed-el

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69216 Bug ID: 69216 Summary: META-INT/services is missing from tomcat-embed-el Product: Tomcat 10 Version: 10.1.26 Hardware: PC OS: Mac OS X 10.1 Status: NEW

[Bug 69180] Windows Tomcat service crashes in certain cases

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69180 qoo...@gmail.com changed: What|Removed |Added CC|jmalo...@opentext.com | -- You are receiving this mail bec

Buildbot failure in on tomcat-9.0.x

2024-07-23 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/1019 Blamelist: Mark Thomas , Michael Clarke Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x] 28dc9f42b1210a2cbeef

Re: TCK CI runs

2024-07-23 Thread Rémy Maucherat
On Mon, Jul 22, 2024 at 6:54 PM Mark Thomas wrote: > > All, > > Today I have configured the tomcat-tck repository to run the EL, > Servlet, Pages and WebSocket TCKs once every day for all combinations of > JDK 17 & 21, Ubuntu latest, MacOS latest and Windows latest using GitHub > actions. > > Ther

(tomcat) branch main updated: Restore only creating Stream input buffer when required

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d5305cafae Restore only creating Stream input buffer

(tomcat) branch 9.0.x updated: Restore only creating Stream input buffer when required

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 28dc9f42b1 Restore only creating Stream input buffe

(tomcat) branch 10.1.x updated: Restore only creating Stream input buffer when required

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new bcc79ecda6 Restore only creating Stream input buf

(tomcat) branch 9.0.x updated: Code review. InputBuffer is never null.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9092078742 Code review. InputBuffer is never null.

(tomcat) branch 10.1.x updated: Code review. InputBuffer is never null.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 7ed943d63c Code review. InputBuffer is never null

(tomcat) branch main updated: Code review. InputBuffer is never null.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 4c19a89c52 Code review. InputBuffer is never null. 4c

(tomcat) branch 9.0.x updated: Align with 10.1.x/11.0.x

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new baeb8ce2f1 Align with 10.1.x/11.0.x baeb8ce2f1 is d

(tomcat) branch 10.1.x updated: Clean-up - formatting. No functional change.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 1e1ba0189d Clean-up - formatting. No functional c

(tomcat) branch 9.0.x updated: Clean-up - formatting. No functional change.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 8ecc672651 Clean-up - formatting. No functional cha

(tomcat) branch main updated: Clean-up - formatting. No functional change.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new ee5bfc7f39 Clean-up - formatting. No functional chang

(tomcat) branch 9.0.x updated: Clean-up - formatting. No functional change.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 30dc8a1f61 Clean-up - formatting. No functional cha

(tomcat) branch 10.1.x updated: Clean-up - formatting. No functional change.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 5fc9bc6f6e Clean-up - formatting. No functional c

(tomcat) branch main updated: Clean-up - formatting. No functional change.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new ff802b3b32 Clean-up - formatting. No functional chang

Re: [VOTE] Release Apache Tomcat Native 1.3.1

2024-07-23 Thread Mark Thomas
Ping. We are 1 PMC member +1 vote short for this release. Mark On 18/07/2024 11:00, Mark Thomas wrote: The key differences compared to 1.3.0 are: - Fix a crash on Windows when SSLContext.setCACertificate() is invoked   with a null value for caCertificateFile and a non-null value for   caCer

Re: [VOTE] Release Apache Tomcat Native 2.0.8

2024-07-23 Thread Mark Thomas
Ping. We are 1 PMC member +1 vote short for this release. Mark On 17/07/2024 20:51, Mark Thomas wrote: The key differences of version 2.0.8 compared to 2.0.7 are: - Fix a crash on Windows when SSLContext.setCACertificate() is invoked   with a null value for caCertificateFile and a non-null va

[Bug 68295] Connection has already been closed - Tomcat connection pool

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68295 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

(tomcat) branch 9.0.x updated (a2da7fbf8b -> 6cef465571)

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from a2da7fbf8b Fix BZ 69214. CORS. POST with no content-type is not a reason to reject new a008c8f563 Correctly Proxy

[Bug 69206] jdbc-pool is not returning the proxied Statement from a ResultSet

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69206 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

(tomcat) 02/02: Follow-up to BZ 69206 fix. Change log entry and code clean-up.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6cef465571cb898684e182e7a184f24d3797342b Author: Mark Thomas AuthorDate: Tue Jul 23 10:21:40 2024 +0100 Follow-up to

(tomcat) 01/02: Correctly Proxy Statement returned from ResultSet

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a008c8f5631794c06da9de9354d8d478b070f8b2 Author: Michael Clarke AuthorDate: Thu Jul 18 17:05:57 2024 +0100 Correctly

(tomcat) 01/02: Correctly Proxy Statement returned from ResultSet

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit aa0a9932f0d8813a1ab1cb3597fa79e02acf24ee Author: Michael Clarke AuthorDate: Thu Jul 18 17:05:57 2024 +0100 Correctly

(tomcat) 02/02: Follow-up to BZ 69206 fix. Change log entry and code clean-up.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2b3776ad46eea15bce2080d3e7be4bfd47f51790 Author: Mark Thomas AuthorDate: Tue Jul 23 10:21:40 2024 +0100 Follow-up to

(tomcat) branch 10.1.x updated (9e1aebd2d1 -> 2b3776ad46)

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 9e1aebd2d1 Fix BZ 69214. CORS. POST with no content-type is not a reason to reject new aa0a9932f0 Correctly Proxy

(tomcat) branch main updated: Follow-up to BZ 69206 fix. Change log entry and code clean-up.

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 3539add5ee Follow-up to BZ 69206 fix. Change log entr

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-07-23 Thread via GitHub
markt-asf commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2244574724 Thanks for the PR. All looks reasonable to me. There are a few bits of potential clean-up I noticed both in the patch and the surrounding code. I'll do that after I've merged this PR. --

(tomcat) branch main updated: Correctly Proxy Statement returned from ResultSet

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new fad2a3f649 Correctly Proxy Statement returned from Re

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-07-23 Thread via GitHub
markt-asf merged PR #742: URL: https://github.com/apache/tomcat/pull/742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[Bug 65347] The equals method from statements generated by the StatementFacade throws both Illegal Argument Exception and NullPointerExceptions

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65347 Mark Thomas changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

[Bug 69206] jdbc-pool is not returning the proxied Statement from a ResultSet

2024-07-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69206 Mark Thomas changed: What|Removed |Added CC||pj.stan...@live.co.uk --- Comment #2 fro

(tomcat-tck) branch main updated: Cache the Maven dependencies to reduce repeated downloads

2024-07-23 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-tck.git The following commit(s) were added to refs/heads/main by this push: new ed98234 Cache the Maven dependencies to reduce r

Re: TCK CI runs

2024-07-23 Thread Mark Thomas
On 22/07/2024 23:33, Christopher Schultz wrote: Mark, On 7/22/24 12:53, Mark Thomas wrote: All, Today I have configured the tomcat-tck repository to run the EL, Servlet, Pages and WebSocket TCKs once every day for all combinations of JDK 17 & 21, Ubuntu latest, MacOS latest and Windows lates